Skip to content

Commit 38dedac

Browse files
committed
use finally clause
1 parent 1e22467 commit 38dedac

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/auth/index.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,11 @@ export class Authenticator {
176176
this.rwlock.readLock(releaseReadLock => {
177177
try {
178178
const cachedToken = this.getCachedToken();
179-
releaseReadLock();
180179
resolve(cachedToken);
181180
} catch (error) {
182-
// Make sure to avoid deadlocks in case of errors
183-
releaseReadLock();
184181
reject(error instanceof Error ? error : new Error(String(error)));
182+
} finally {
183+
releaseReadLock();
185184
}
186185
});
187186
});
@@ -201,12 +200,11 @@ export class Authenticator {
201200

202201
await this.performAuthentication();
203202

204-
releaseWriteLock();
205203
resolve();
206204
} catch (error) {
207-
// Make sure to avoid deadlocks in case of errors
208-
releaseWriteLock();
209205
reject(error instanceof Error ? error : new Error(String(error)));
206+
} finally {
207+
releaseWriteLock();
210208
}
211209
});
212210
});

0 commit comments

Comments
 (0)