feat: FIR-42655 firebolt node sdk draining engine status not recognized (#129)

Author: stepansergeevitch

src/service/engine/model.ts

@@ -52,7 +52,7 @@ export class EngineModel {
   }
 
   async delete() {
-    if (this.current_status_summary == EngineStatusSummary.DELETING) {
+    if (this.current_status_summary == EngineStatusSummary.DRAINING) {
       return;
     }
     const query = `DROP ENGINE "${this.name}"`;

src/service/engine/types.ts

@@ -26,11 +26,10 @@ export function processEngineStatus(
 }
 
 export enum EngineStatusSummary {
-  DELETING = "Dropping",
-  REPAIRING = "Repairing",
-  RUNNING = "Running",
   STARTING = "Starting",
-  STARTING_INITIALIZING = "Started",
+  RUNNING = "Running",
+  RESIZING = "Resizing",
+  DRAINING = "Draining",
   STOPPED = "Stopped",
   STOPPING = "Stopping",
   // Specific for V1, here are just for typing match
@@ -39,7 +38,9 @@ export enum EngineStatusSummary {
   RESTARTING = "ENGINE_STATUS_SUMMARY_RESTARTING",
   RESTARTING_INITIALIZING = "ENGINE_STATUS_SUMMARY_RESTARTING_INITIALIZING",
   UNSPECIFIED = "ENGINE_STATUS_SUMMARY_UNSPECIFIED",
-  UPGRADING = "ENGINE_STATUS_SUMMARY_UPGRADING"
+  UPGRADING = "ENGINE_STATUS_SUMMARY_UPGRADING",
+  REPAIRING = "ENGINE_STATUS_SUMMARY_REPAIRING",
+  STARTING_INITIALIZING = "ENGINE_STATUS_SUMMARY_STARTING_INITIALIZING",
 }
 
 export enum EngineType {

src/service/engine/v1/types.ts

@@ -9,7 +9,7 @@ export type Engine = {
 };
 
 export enum EngineStatusSummary {
-  DELETING = "ENGINE_STATUS_SUMMARY_DELETING",
+  DRAINING = "ENGINE_STATUS_SUMMARY_DELETING",
   REPAIRING = "ENGINE_STATUS_SUMMARY_REPAIRING",
   RUNNING = "ENGINE_STATUS_SUMMARY_RUNNING",
   STARTING = "ENGINE_STATUS_SUMMARY_STARTING",

test/integration/v2/geography.test.ts

@@ -0,0 +1,35 @@
+import { Firebolt } from "../../../src/index";
+
+const connectionParams = {
+  auth: {
+    client_id: process.env.FIREBOLT_CLIENT_ID as string,
+    client_secret: process.env.FIREBOLT_CLIENT_SECRET as string
+  },
+  account: process.env.FIREBOLT_ACCOUNT as string,
+  database: process.env.FIREBOLT_DATABASE as string,
+  engineName: process.env.FIREBOLT_ENGINE_NAME as string
+};
+
+jest.setTimeout(100000);
+
+describe("geography", () => {
+  it("handles select geo", async () => {
+    const firebolt = Firebolt({
+      apiEndpoint: process.env.FIREBOLT_API_ENDPOINT as string
+    });
+
+    const connection = await firebolt.connect(connectionParams);
+
+    await connection.execute("SET advanced_mode=1");
+    await connection.execute("SET enable_geography=true");
+
+    const statement = await connection.execute(
+      "select 'POINT(1 1)'::geography;"
+    );
+
+    const { data, meta } = await statement.fetchResult();
+    expect(meta[0].type).toEqual("geography");
+    const row = data[0];
+    expect((row as unknown[])[0]).toEqual("0101000020E6100000FEFFFFFFFFFFEF3F000000000000F03F");
+  });
+});

test/unit/v2/engine.test.ts

@@ -589,6 +589,23 @@ describe("engine service", () => {
     delete process.env.ENGINE_NAME;
   });
 
+  it("Parse engine statuses", async () => {
+    // Taken from https://docs.firebolt.io/Overview/engine-fundamentals.html#viewing-and-understanding-engine-status
+    const statuses = [
+      ["STARTING", EngineStatusSummary.STARTING],
+      ["RUNNING", EngineStatusSummary.RUNNING],
+      ["RESIZING", EngineStatusSummary.RESIZING],
+      ["DRAINING", EngineStatusSummary.DRAINING],
+      ["STOPPING", EngineStatusSummary.STOPPING],
+      ["STOPPED", EngineStatusSummary.STOPPED]
+    ];
+    for (const [rawStatus, status] of statuses) {
+      expect(processEngineStatus(rawStatus)).toEqual(status);
+    }
+    expect(processEngineStatus(undefined)).toBe(undefined);
+    expect(processEngineStatus("unexisting")).not.toBeTruthy();
+  });
+
   it("Parses different engine statuses correctly", async () => {
     const statuses = ["RUNNING", "Running", "running"];
     for (const status of statuses) {