Hiding internal settings from types

Author: ptiurin

src/connection/base.ts

@@ -81,7 +81,15 @@ export abstract class Connection {
     const strSettings = Object.entries(settings ?? {}).reduce<
       Record<string, string>
     >((acc, [key, value]) => {
-      if (value !== undefined) {
+      if (key === "internal") {
+        // Unwrap internal settings from array
+        const internalSettings = value as Record<string, string | number>[];
+        internalSettings.forEach(setting => {
+          Object.entries(setting).forEach(([internalKey, internalValue]) => {
+            acc[internalKey] = internalValue.toString();
+          });
+        });
+      } else if (value !== undefined) {
         acc[key] = value.toString();
       }
       return acc;

src/core/index.ts

@@ -1,11 +1,6 @@
 import { makeConnection } from "../connection";
 import { Authenticator } from "../auth";
-import {
-  Context,
-  ConnectionOptions,
-  FireboltClientOptions,
-  SettingValues
-} from "../types";
+import { Context, ConnectionOptions, FireboltClientOptions } from "../types";
 import { ResourceManager } from "../service";
 
 export class FireboltCore {
@@ -38,7 +33,7 @@ export class FireboltCore {
     await connection.resolveEngineEndpoint();
     // auto_start_stop_control is only available for v2
     const settings = auth.isServiceAccount()
-      ? { auto_start_stop_control: SettingValues.IGNORE }
+      ? { internal: [{ auto_start_stop_control: "ignore" }] }
       : {};
     await connection.execute("select 1", { settings });
   }

src/types.ts

@@ -29,16 +29,12 @@ export enum OutputFormat {
   JSON = "JSON"
 }
 
-export enum SettingValues {
-  IGNORE = "ignore"
-}
-
 export type QuerySettings = Record<
   string,
-  string | number | boolean | undefined
+  string | number | boolean | undefined | Record<string, string | number>[]
 > & {
   output_format?: OutputFormat;
-  auto_start_stop_control?: SettingValues;
+  internal?: Record<string, string | number>[];
 };
 
 export type RowParser = (row: string, isLastRow: boolean) => any;