feat: FIR-42655 firebolt node sdk draining engine status not recognized #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ptiurin
reviewed
Jan 28, 2025
Contributor
There was a problem hiding this comment.
Generally let's try to avoid bundling unrelated changes, this makes it harder to make sense of them when viewing change history.
Contributor
Author
There was a problem hiding this comment.
Agree, this were just something I did some time ago and forgot to push
Comment on lines
+41
to
+43
| UPGRADING = "ENGINE_STATUS_SUMMARY_UPGRADING", | ||
| REPAIRING = "ENGINE_STATUS_SUMMARY_REPAIRING", | ||
| STARTING_INITIALIZING = "ENGINE_STATUS_SUMMARY_STARTING_INITIALIZING", |
Contributor
There was a problem hiding this comment.
Do you have a link for these? I don't see them defined anywhere apart from v1 code paths in firebolt-analytics.
Contributor
Author
There was a problem hiding this comment.
As the comment above mentions, these are here only for type match, they are not real statuses for V2
ptiurin
approved these changes
Jan 29, 2025
stepansergeevitch
deleted the
FIR-42655-firebolt-node-sdk-draining-engine-status-not-recognized-causing-cube-ci-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing engine V2 statuses for node resource manager.
Also added missing geography type test