Skip to content

test: Fix nullability test in struct #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

test: Fix nullability test in struct #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8712e
test: Fix nullability test in struct
ptiurin Feb 27, 2025
2afc955
fix struct flags
ptiurin Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/integration/v2/fetchTypes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,15 @@ describe("test type casting on fetch", () => {
engineName: process.env.FIREBOLT_ENGINE_NAME as string
});
await connection.execute("SET advanced_mode=1");
await connection.execute("SET enable_struct=1");
await connection.execute("SET enable_create_table_v2=true");
await connection.execute("SET enable_row_selection=true");
await connection.execute("SET enable_struct_syntax=true");
await connection.execute("SET prevent_create_on_information_schema=true");
await connection.execute("SET enable_create_table_with_struct_type=true");
await connection.execute("DROP TABLE IF EXISTS test_struct");
await connection.execute("DROP TABLE IF EXISTS test_struct_helper");
try {
await connection.execute(
"CREATE TABLE IF NOT EXISTS test_struct(id int not null, s struct(a array(int) not null, b bytea null) not null)"
"CREATE TABLE IF NOT EXISTS test_struct(id int not null, s struct(a array(int) null, b bytea null) not null)"
);
await connection.execute(
"CREATE TABLE IF NOT EXISTS test_struct_helper(a array(int) not null, b bytea null)"
Expand All @@ -140,7 +139,7 @@ describe("test type casting on fetch", () => {

const { data, meta } = await statement.fetchResult();
expect(meta[0].type).toEqual(
"struct(id int, s struct(a array(int null), b bytea null))"
"struct(id int, s struct(a array(int null) null, b bytea null))"
);
const row = data[0];
expect((row as unknown[])[0]).toEqual({
Expand Down