fix: pytests now pass with pytest-asyncio v0.19.0 (#189)

* Added pytest_asyncio to fixture decorators for connection and cursor defs in conftest to pass unit tests using pytest-asyncio>=0.19.0.

* Started adding pytest_asyncio to fixture decorators in integration tests.

* Added pytest_asyncio to fixtures in integration async conftest modules. Some integration tests still aren't passing.

* Changed pytest.fixture and pytest_asyncio.fixture imports to be more consistent.

* Pinned pytest-asyncio version to 0.19.0.

* Had missed a few pytest_asyncio.fixture -> asyncfixture imports.

Author: ericf-firebolt

setup.cfg

@@ -49,7 +49,7 @@ dev =
     pre-commit==2.15.0
     pyfakefs>=4.5.3
     pytest==6.2.5
-    pytest-asyncio<0.19.0
+    pytest-asyncio==0.19.0
     pytest-cov==3.0.0
     pytest-httpx==0.21.0
     pytest-mock==3.6.1

tests/integration/conftest.py

@@ -2,6 +2,7 @@
 from os import environ
 
 from pytest import fixture
+from pytest_asyncio import fixture as async_fixture
 
 from firebolt.service.manager import Settings
 
@@ -24,7 +25,7 @@ def must_env(var_name: str) -> str:
     return environ[var_name]
 
 
-@fixture(scope="session")
+@async_fixture(scope="session")
 def rm_settings(api_endpoint, username, password) -> Settings:
     return Settings(
         server=api_endpoint,

tests/integration/dbapi/async/conftest.py

@@ -1,9 +1,9 @@
-from pytest import fixture
+from pytest_asyncio import fixture as async_fixture
 
 from firebolt.async_db import Connection, connect
 
 
-@fixture
+@async_fixture
 async def connection(
     engine_url: str,
     database_name: str,
@@ -23,7 +23,7 @@ async def connection(
         yield connection
 
 
-@fixture
+@async_fixture
 async def connection_engine_name(
     engine_name: str,
     database_name: str,
@@ -44,7 +44,7 @@ async def connection_engine_name(
         yield connection
 
 
-@fixture
+@async_fixture
 async def connection_no_engine(
     database_name: str,
     username: str,

tests/integration/dbapi/sync/conftest.py

@@ -1,9 +1,9 @@
-from pytest import fixture
+from pytest_asyncio import fixture as async_fixture
 
 from firebolt.db import Connection, connect
 
 
-@fixture
+@async_fixture
 def connection(
     engine_url: str,
     database_name: str,
@@ -24,7 +24,7 @@ def connection(
     connection.close()
 
 
-@fixture
+@async_fixture
 def connection_engine_name(
     engine_name: str,
     database_name: str,
@@ -45,7 +45,7 @@ def connection_engine_name(
     connection.close()
 
 
-@fixture
+@async_fixture
 def connection_no_engine(
     database_name: str,
     username: str,

tests/unit/async_db/conftest.py

@@ -2,6 +2,7 @@
 from typing import Dict
 
 from pytest import fixture
+from pytest_asyncio import fixture as asyncio_fixture
 
 from firebolt.async_db import (
     ARRAY,
@@ -15,7 +16,7 @@
 from tests.unit.db_conftest import *  # noqa
 
 
-@fixture
+@asyncio_fixture
 async def connection(settings: Settings, db_name: str) -> Connection:
     async with (
         await connect(
@@ -30,7 +31,7 @@ async def connection(settings: Settings, db_name: str) -> Connection:
         yield connection
 
 
-@fixture
+@asyncio_fixture
 async def cursor(connection: Connection, settings: Settings) -> Cursor:
     return connection.cursor()
 

tests/unit/client/conftest.py

@@ -2,33 +2,33 @@
 import typing
 
 import httpx
-import pytest
 from httpx import Response
+from pytest import fixture
 
 from firebolt.common.settings import Settings
 
 
-@pytest.fixture
+@fixture
 def test_token(access_token: str) -> str:
     return access_token
 
 
-@pytest.fixture
+@fixture
 def test_token2() -> str:
     return "test_token2"
 
 
-@pytest.fixture
+@fixture
 def test_username(settings: Settings) -> str:
     return settings.user
 
 
-@pytest.fixture
+@fixture
 def test_password(settings: Settings) -> str:
     return settings.password.get_secret_value()
 
 
-@pytest.fixture
+@fixture
 def check_credentials_callback(
     test_username: str, test_password: str, test_token: str
 ) -> typing.Callable: