Skip to content

Commit 31e558d

Browse files
authored
ci: Fix secrets in release action (#324)
1 parent bb1dc73 commit 31e558d

File tree

4 files changed

+18
-22
lines changed

4 files changed

+18
-22
lines changed

.github/workflows/integration-tests-v1.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ on:
1616
default: 'staging'
1717
required: false
1818
type: string
19-
branch:
20-
required: false
21-
type: string
22-
description: 'Branch to run on'
2319
secrets:
2420
FIREBOLT_USERNAME:
2521
required: true
@@ -33,14 +29,16 @@ on:
3329
required: true
3430
SERVICE_SECRET:
3531
required: true
32+
SERVICE_ID_STG:
33+
required: true
34+
SERVICE_SECRET_STG:
35+
required: true
3636
jobs:
3737
tests:
3838
runs-on: ubuntu-latest
3939
steps:
4040
- name: Check out code
4141
uses: actions/checkout@v2
42-
with:
43-
ref: ${{ inputs.branch }}
4442

4543
- name: Set up Python 3.7
4644
uses: actions/setup-python@v2
@@ -62,8 +60,8 @@ jobs:
6260
else
6361
echo "USERNAME=${{ secrets.FIREBOLT_USERNAME }}" >> "$GITHUB_ENV"
6462
echo "PASSWORD=${{ secrets.FIREBOLT_PASSWORD }}" >> "$GITHUB_ENV"
65-
echo "CLIENT_ID=${{ secrets.FIREBOLT_CLIENT_ID }}" >> "$GITHUB_ENV"
66-
echo "CLIENT_SECRET=${{ secrets.FIREBOLT_CLIENT_SECRET }}" >> "$GITHUB_ENV"
63+
echo "CLIENT_ID=${{ secrets.SERVICE_ID }}" >> "$GITHUB_ENV"
64+
echo "CLIENT_SECRET=${{ secrets.SERVICE_SECRET }}" >> "$GITHUB_ENV"
6765
fi
6866
6967
- name: Setup database and engine

.github/workflows/integration-tests-v2.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ on:
1616
default: 'staging'
1717
required: false
1818
type: string
19-
branch:
20-
required: false
21-
type: string
22-
description: 'Branch to run on'
2319
secrets:
2420
FIREBOLT_CLIENT_ID_STG_NEW_IDN:
2521
required: true
@@ -35,8 +31,6 @@ jobs:
3531
steps:
3632
- name: Check out code
3733
uses: actions/checkout@v2
38-
with:
39-
ref: ${{ inputs.branch }}
4034

4135
- name: Set up Python 3.7
4236
uses: actions/setup-python@v2

.github/workflows/integration-tests.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ on:
1616
default: 'staging'
1717
required: false
1818
type: string
19-
branch:
20-
required: false
21-
type: string
22-
description: 'Branch to run on'
2319
secrets:
2420
FIREBOLT_USERNAME:
2521
required: true
@@ -33,6 +29,10 @@ on:
3329
required: true
3430
SERVICE_SECRET:
3531
required: true
32+
SERVICE_ID_STG:
33+
required: true
34+
SERVICE_SECRET_STG:
35+
required: true
3636
# V2 secrets
3737
FIREBOLT_CLIENT_ID_STG_NEW_IDN:
3838
required: true
@@ -46,20 +46,20 @@ jobs:
4646
integration-test-v1:
4747
uses: ./.github/workflows/integration-tests-v1.yml
4848
with:
49-
environment: ${{ github.event.inputs.environment }}
50-
branch: ${{ github.event.inputs.branch }}
49+
environment: ${{ inputs.environment }}
5150
secrets:
5251
FIREBOLT_USERNAME: ${{ secrets.FIREBOLT_USERNAME }}
5352
FIREBOLT_PASSWORD: ${{ secrets.FIREBOLT_PASSWORD }}
5453
FIREBOLT_STG_USERNAME: ${{ secrets.FIREBOLT_STG_USERNAME }}
5554
FIREBOLT_STG_PASSWORD: ${{ secrets.FIREBOLT_STG_PASSWORD }}
5655
SERVICE_ID: ${{ secrets.SERVICE_ID }}
5756
SERVICE_SECRET: ${{ secrets.SERVICE_SECRET }}
57+
SERVICE_ID_STG: ${{ secrets.SERVICE_ID_STG }}
58+
SERVICE_SECRET_STG: ${{ secrets.SERVICE_SECRET_STG }}
5859
integration-test-v2:
5960
uses: ./.github/workflows/integration-tests-v2.yml
6061
with:
61-
environment: ${{ github.event.inputs.environment }}
62-
branch: ${{ github.event.inputs.branch }}
62+
environment: ${{ inputs.environment }}
6363
secrets:
6464
FIREBOLT_CLIENT_ID_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
6565
FIREBOLT_CLIENT_SECRET_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}

.github/workflows/release.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ on:
1313
jobs:
1414
integration-tests:
1515
uses: ./.github/workflows/integration-tests.yml
16+
with:
17+
environment: "staging"
1618
secrets:
1719
FIREBOLT_CLIENT_ID_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
1820
FIREBOLT_CLIENT_SECRET_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
@@ -24,6 +26,8 @@ jobs:
2426
FIREBOLT_STG_PASSWORD: ${{ secrets.FIREBOLT_STG_PASSWORD }}
2527
SERVICE_ID: ${{ secrets.SERVICE_ID }}
2628
SERVICE_SECRET: ${{ secrets.SERVICE_SECRET }}
29+
SERVICE_ID_STG: ${{ secrets.SERVICE_ID_STG }}
30+
SERVICE_SECRET_STG: ${{ secrets.SERVICE_SECRET_STG }}
2731

2832
publish:
2933
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)