Skip to content

Commit 510ccbc

Browse files
authored
test: Fix rowcount tests (#253)
1 parent 7c273b5 commit 510ccbc

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

tests/integration/dbapi/async/test_queries_async.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,20 +195,13 @@ async def test_long_query(
195195
assert len(data) == 360, "Invalid data size returned by fetchall"
196196

197197

198-
async def test_drop_create(
199-
connection: Connection, create_drop_description: List[Column]
200-
) -> None:
198+
async def test_drop_create(connection: Connection) -> None:
201199
"""Create and drop table/index queries are handled properly."""
202200

203201
async def test_query(c: Cursor, query: str) -> None:
204-
assert await c.execute(query) == 1, "Invalid row count returned"
205-
assert c.rowcount == 1, "Invalid rowcount value"
206-
assert_deep_eq(
207-
c.description,
208-
create_drop_description,
209-
"Invalid create table query description",
210-
)
211-
assert len(await c.fetchall()) == 1, "Invalid data returned"
202+
await c.execute(query)
203+
assert c.description == None
204+
assert c.rowcount == -1
212205

213206
"""Create table query is handled properly"""
214207
with connection.cursor() as c:

tests/integration/dbapi/sync/test_queries.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -146,20 +146,13 @@ def test_long_query(
146146
assert len(data) == 360, "Invalid data size returned by fetchall"
147147

148148

149-
def test_drop_create(
150-
connection: Connection, create_drop_description: List[Column]
151-
) -> None:
149+
def test_drop_create(connection: Connection) -> None:
152150
"""Create and drop table/index queries are handled properly."""
153151

154152
def test_query(c: Cursor, query: str) -> None:
155-
assert c.execute(query) == 1, "Invalid row count returned"
156-
assert c.rowcount == 1, "Invalid rowcount value"
157-
assert_deep_eq(
158-
c.description,
159-
create_drop_description,
160-
"Invalid create table query description",
161-
)
162-
assert len(c.fetchall()) == 1, "Invalid data returned"
153+
c.execute(query)
154+
assert c.description == None
155+
assert c.rowcount == -1
163156

164157
"""Create table query is handled properly"""
165158
with connection.cursor() as c:

0 commit comments

Comments
 (0)