fix: resolve cyclic dependency (#346)

Author: stepansergeevitch

src/firebolt/async_db/connection.py

@@ -11,7 +11,7 @@
 from firebolt.client.auth import Auth
 from firebolt.client.client import AsyncClient, AsyncClientV1, AsyncClientV2
 from firebolt.common.base_connection import BaseConnection
-from firebolt.common.settings import DEFAULT_TIMEOUT_SECONDS
+from firebolt.common.constants import DEFAULT_TIMEOUT_SECONDS
 from firebolt.utils.exception import (
     ConfigurationError,
     ConnectionClosedError,

src/firebolt/async_db/util.py

@@ -4,7 +4,7 @@
 
 from firebolt.client.auth import Auth
 from firebolt.client.client import AsyncClientV2
-from firebolt.common.settings import DEFAULT_TIMEOUT_SECONDS
+from firebolt.common.constants import DEFAULT_TIMEOUT_SECONDS
 from firebolt.utils.exception import (
     AccountNotFoundOrNoAccessError,
     InterfaceError,

src/firebolt/client/http_backend.py

@@ -10,7 +10,7 @@
 
 from httpx import AsyncHTTPTransport, HTTPTransport
 
-from firebolt.common.settings import KEEPALIVE_FLAG, KEEPIDLE_RATE
+from firebolt.common.constants import KEEPALIVE_FLAG, KEEPIDLE_RATE
 
 
 def override_stream(stream):  # type: ignore [no-untyped-def]

src/firebolt/common/constants.py

@@ -0,0 +1,3 @@
+KEEPALIVE_FLAG: int = 1
+KEEPIDLE_RATE: int = 60  # seconds
+DEFAULT_TIMEOUT_SECONDS: int = 60

src/firebolt/common/settings.py

@@ -7,11 +7,6 @@
 
 logger = logging.getLogger(__name__)
 
-KEEPALIVE_FLAG: int = 1
-
-KEEPIDLE_RATE: int = 60  # seconds
-DEFAULT_TIMEOUT_SECONDS: int = 60
-
 CLIENT_ID_ENV = "FIREBOLT_CLIENT_ID"
 CLIENT_SECRET_ENV = "FIREBOLT_CLIENT_SECRET"
 ACCOUNT_ENV = "FIREBOLT_ACCOUNT"

src/firebolt/db/connection.py

@@ -10,7 +10,7 @@
 from firebolt.client import DEFAULT_API_URL, Client, ClientV1, ClientV2
 from firebolt.client.auth import Auth
 from firebolt.common.base_connection import BaseConnection
-from firebolt.common.settings import DEFAULT_TIMEOUT_SECONDS
+from firebolt.common.constants import DEFAULT_TIMEOUT_SECONDS
 from firebolt.db.cursor import Cursor, CursorV1, CursorV2
 from firebolt.db.util import _get_system_engine_url
 from firebolt.utils.exception import (

src/firebolt/db/util.py

@@ -4,7 +4,7 @@
 
 from firebolt.client import ClientV2
 from firebolt.client.auth import Auth
-from firebolt.common.settings import DEFAULT_TIMEOUT_SECONDS
+from firebolt.common.constants import DEFAULT_TIMEOUT_SECONDS
 from firebolt.utils.exception import (
     AccountNotFoundOrNoAccessError,
     InterfaceError,

tests/unit/common/test_exceptions.py

@@ -0,0 +1,2 @@
+def test_has_firebolt_error():
+    from firebolt.common.exception import FireboltError  # NOQA