refactor: Simplify Core connection validation per PR feedback

- Remove engine_name and account_name validation checks from _validate_core_connection
- Keep only credentials validation since FireboltCore auth handles other parameters
- Update unit tests to reflect new validation behavior
- Address GitHub comment from ptiurin requesting simplified validation

Co-Authored-By: [email protected] <[email protected]>

Author: devin-ai-integration[bot]

src/firebolt_db/firebolt_dialect.py

@@ -170,19 +170,12 @@ def create_connect_args(self, url: URL) -> Tuple[List, Dict]:
     def _validate_core_connection(self, url: URL, parameters: Dict[str, str]) -> None:
         """Validate that Core connection parameters are correct.
         
-        Note: In SQLAlchemy URL structure, url.database maps to engine_name
-        and url.host maps to database name in Firebolt context.
+        Only validates credentials since FireboltCore auth handles other parameters.
         """
         if url.username or url.password:
             raise ArgumentError(
                 "Core connections do not support username/password authentication"
             )
-        if url.database:
-            raise ArgumentError("Core connections do not support engine_name parameter")
-        if "account_name" in parameters:
-            raise ArgumentError(
-                "Core connections do not support account_name parameter"
-            )
 
     def _parse_token_cache_flag(self, parameters: Dict[str, str]) -> bool:
         """Parse and remove token cache flag from parameters."""

tests/unit/test_firebolt_dialect.py

@@ -352,30 +352,29 @@ def test_create_connect_args_core_with_credentials_error(
         ):
             dialect.create_connect_args(u)
 
-    def test_create_connect_args_core_with_engine_error(self, dialect: FireboltDialect):
+    def test_create_connect_args_core_with_engine_allowed(self, dialect: FireboltDialect):
+        """Test that Core connections now allow engine_name parameter."""
         connection_url = (
             "test_engine://test_db_name/test_engine?url=http://localhost:8080"
         )
         u = url.make_url(connection_url)
+        
+        result_list, result_dict = dialect.create_connect_args(u)
+        assert result_dict["engine_name"] == "test_engine"
+        assert result_dict["url"] == "http://localhost:8080"
 
-        with raises(
-            ArgumentError, match="Core connections do not support engine_name parameter"
-        ):
-            dialect.create_connect_args(u)
-
-    def test_create_connect_args_core_with_account_error(
+    def test_create_connect_args_core_with_account_allowed(
         self, dialect: FireboltDialect
     ):
+        """Test that Core connections now allow account_name parameter."""
         connection_url = (
             "test_engine://test_db_name?url=http://localhost:8080&account_name=test"
         )
         u = url.make_url(connection_url)
-
-        with raises(
-            ArgumentError,
-            match="Core connections do not support account_name parameter",
-        ):
-            dialect.create_connect_args(u)
+        
+        result_list, result_dict = dialect.create_connect_args(u)
+        assert result_dict["account_name"] == "test"
+        assert result_dict["url"] == "http://localhost:8080"
 
 
 def test_get_is_nullable():