shortenValueGrip has been introduced in Fx38, support also Fx36

Author: janodvarko

lib/jquery-renderer.js

@@ -14,6 +14,9 @@ const { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {})
 const { Widgets } = devtools.require("devtools/webconsole/console-output");
 const { VariablesView } = Cu.import("resource:///modules/devtools/VariablesView.jsm", {});
 
+// Platform
+const { Services } = Cu.import("resource://gre/modules/Services.jsm", {});
+
 const XHTML_NS = "http://www.w3.org/1999/xhtml";
 
 /**
@@ -57,7 +60,10 @@ var JQueryRenderer = {
           emptySlots = 0;
         }
 
-        let shortVal = this.message.shortenValueGrip(item);
+        // shortenValueGrip API has been introduced in Firefox 38
+        let shortVal = this.message.shortenValueGrip ?
+          this.message.shortenValueGrip(item) : shortenValueGrip();
+
         let elem = this.message._renderValueGrip(shortVal, { concise: true });
         this.element.appendChild(elem);
 
@@ -122,6 +128,29 @@ var JQueryRenderer = {
   }
 };
 
+// Helpers
+
+/**
+ * Can be removed when Firefox 38 (Fx38) is the minimum required version.
+ */
+function shortenValueGrip(grip) {
+  let MAX_STRING_GRIP_LENGTH = 36;
+  let ELLIPSIS = Services.prefs.getComplexValue("intl.ellipsis",
+    Ci.nsIPrefLocalizedString).data;
+
+  let shortVal = grip;
+  if (typeof(grip)=="string") {
+    shortVal = grip.replace(/(\r\n|\n|\r)/gm," ");
+    if (shortVal.length > MAX_STRING_GRIP_LENGTH) {
+      shortVal = shortVal.substring(0, MAX_STRING_GRIP_LENGTH - 1) + ELLIPSIS;
+    }
+  }
+
+  return shortVal;
+}
+
+// Registration
+
 Widgets.ObjectRenderers.add(JQueryRenderer);
 
 // Exports from this module