#32 DebuggerServer.ObjectActorPreviewers is undefined

Author: janodvarko

lib/firequery-actor.js

@@ -12,14 +12,18 @@
 const { Cu, Ci, components } = require("chrome");
 
 // DevTools
-const { DebuggerServer } = Cu.import("resource://gre/modules/devtools/dbg-server.jsm", {});
 const { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
-const protocol = devtools["require"]("devtools/server/protocol");
-const { method, RetVal, ActorClass, Actor, Arg, types } = protocol;
+const { DebuggerServer } = devtools["require"]("devtools/server/main");
 const Events = devtools["require"]("sdk/event/core");
 const { makeInfallible } = devtools["require"]("devtools/toolkit/DevToolsUtils.js");
 const DevToolsUtils = devtools["require"]("devtools/toolkit/DevToolsUtils");
 const { NodeActor } = devtools["require"]("devtools/server/actors/inspector");
+const protocol = devtools["require"]("devtools/server/protocol");
+const { method, RetVal, ActorClass, Actor, Arg, types } = protocol;
+
+// Make sure the DebuggerServer.ObjectActorPreviewers is initialized.
+// See also: https://github.com/firebug/firequery/issues/32
+const { ObjectActor } = devtools["require"]("devtools/server/actors/object");
 
 // Number of items to preview in objects, arrays, maps, sets, lists,
 // collections, etc.
@@ -52,7 +56,7 @@ function expectState(expectedState, method) {
         ", method: " + method);
 
       let msg = "Wrong State: Expected '" + expectedState + "', but current " +
-        "state is '" + this.state + "'";
+        "state is '" + this.state + "', method: " + method;
 
       return Promise.reject(new Error(msg));
     }
@@ -160,7 +164,8 @@ var FireQueryActor = ActorClass(
 
     this.state = "attached";
 
-    // xxxHonza: it's sometimes undefined (e.g. when enabling installed FQ) FIXME
+    // It's been sometimes undefined (e.g. when enabling installed FQ)
+    // See also: https://github.com/firebug/firequery/issues/32
     let Previewers = DebuggerServer.ObjectActorPreviewers;
     if (typeof Previewers != "undefined") {
       Previewers.Object.unshift(this.onBuildPreview);
@@ -196,7 +201,8 @@ var FireQueryActor = ActorClass(
       win.removeEventListener("firequery-event", this.onDataModified, true);
     }
 
-    // Remove previewer listener (web console).
+    // It's been sometimes undefined (e.g. when enabling installed FQ)
+    // See also: https://github.com/firebug/firequery/issues/32
     let Previewers = DebuggerServer.ObjectActorPreviewers;
     if (typeof Previewers != "undefined") {
       removeItem(Previewers.Object, this.onBuildPreview);