Render jQuery cache indicator

Author: janodvarko

chrome/skin/classic/shared/firequery.css

@@ -3,3 +3,9 @@
 .kind-jQueryObject .cm-variable {
   color: #4B0082;
 }
+
+.kind-jQueryObject .jQueryCache {
+  font-size: 11px;
+  color: #4B0082;
+  margin-left: 2px;
+}

lib/firequery-actor.js

@@ -154,7 +154,7 @@ var FireQueryActor = ActorClass(
         let grip = actor.threadActor.createValueGrip(value);
         items.push(grip);
 
-        let cache = evalJQueryCache(desc.value);
+        let cache = hasJQueryCache(desc.value);
         if (cache) {
           grip.preview.cache = cache;
         }
@@ -221,7 +221,7 @@ function hasJQueryCache(object) {
   var cache = evalJQueryCache(object);
   for (var x in cache) {
     if (cache.hasOwnProperty(x)) {
-      return true;
+      return cache;
     }
   }
 };

lib/jquery-renderer.js

@@ -13,6 +13,8 @@ const { Trace, TraceError } = require("firebug.sdk/lib/core/trace.js").get(modul
 const { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
 const { Widgets } = devtools.require("devtools/webconsole/console-output");
 
+const XHTML_NS = "http://www.w3.org/1999/xhtml";
+
 /**
  * @widget This object represents a widget that is used to render
  * generic jQuery object preview.
@@ -53,19 +55,21 @@ var JQueryRenderer = {
         isFirst = false;
 
         if (emptySlots) {
-          this._renderEmptySlots(emptySlots);
+          this.renderEmptySlots(emptySlots);
           emptySlots = 0;
         }
 
         let shortVal = this.message.shortenValueGrip(item);
         let elem = this.message._renderValueGrip(shortVal, { concise: true });
         this.element.appendChild(elem);
+
+        this.renderCache(item, elem);
       }
     }
 
     if (emptySlots) {
       renderSeparator();
-      this._renderEmptySlots(emptySlots, false);
+      this.renderEmptySlots(emptySlots, false);
     }
 
     let shown = items.length;
@@ -80,14 +84,25 @@ var JQueryRenderer = {
     this._text(" )");
   },
 
-  _renderEmptySlots: function(aNumSlots, aAppendComma=true) {
+  renderEmptySlots: function(aNumSlots, aAppendComma=true) {
     let slotLabel = l10n.getStr("emptySlotLabel");
     let slotText = PluralForm.get(aNumSlots, slotLabel);
     this._text("<" + slotText.replace("#1", aNumSlots) + ">");
     if (aAppendComma) {
       this._text(", ");
     }
   },
+
+  renderCache: function(element, parentNode) {
+    if (!element.preview.cache) {
+      return;
+    }
+
+    let cache = this.document.createElementNS(XHTML_NS, "span");
+    cache.className = "jQueryCache"
+    cache.innerHTML = "&#9993;"
+    parentNode.appendChild(cache);
+  }
 };
 
 Widgets.ObjectRenderers.add(JQueryRenderer);