Skip to content

Commit c80acd4

Browse files
committed
Support for new devtools module paths (bug 912121)
1 parent 6f20aa8 commit c80acd4

File tree

2 files changed

+22
-7
lines changed

2 files changed

+22
-7
lines changed

lib/har-driver-actor.js

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,30 @@
1010

1111
// Add-on SDK
1212
const { Cu, Ci, components } = require("chrome");
13+
const Events = require("sdk/event/core");
1314

1415
// Platform
1516
Cu.import("resource://gre/modules/XPCOMUtils.jsm");
1617

1718
// DevTools
19+
// See also: https://bugzilla.mozilla.org/show_bug.cgi?id=912121
20+
var devtools;
21+
try {
22+
devtools = Cu.import("resource://gre/modules/devtools/shared/Loader.jsm", {});
23+
} catch (err) {
24+
devtools = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
25+
}
26+
27+
var DevToolsUtils;
28+
try {
29+
DevToolsUtils = devtools["require"]("devtools/shared/DevToolsUtils");
30+
} catch (err) {
31+
DevToolsUtils = devtools["require"]("devtools/toolkit/DevToolsUtils");
32+
}
33+
1834
const { DebuggerServer } = Cu.import("resource://gre/modules/devtools/dbg-server.jsm", {});
19-
const { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
2035
const protocol = devtools["require"]("devtools/server/protocol");
2136
const { method, RetVal, ActorClass, Actor, Arg, types } = protocol;
22-
const Events = devtools["require"]("sdk/event/core");
23-
const { makeInfallible } = devtools["require"]("devtools/toolkit/DevToolsUtils.js");
24-
const DevToolsUtils = devtools["require"]("devtools/toolkit/DevToolsUtils");
2537

2638
// For debugging purposes. Note that the tracing module isn't available
2739
// on the backend (in case of remote device debugging).

lib/trigger-toolbox-overlay.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@ const { prefs } = require("sdk/simple-prefs");
1818
const { Services } = Cu.import("resource://gre/modules/Services.jsm", {});
1919

2020
// DevTools
21-
const { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
22-
const { makeInfallible } = devtools["require"]("devtools/toolkit/DevToolsUtils.js");
23-
const { get: getHarOverlay } = devtools["require"]("devtools/netmonitor/har/toolbox-overlay.js");
21+
const { devtools, makeInfallible, safeRequire } = require("firebug.sdk/lib/core/devtools.js");
22+
23+
// https://bugzilla.mozilla.org/show_bug.cgi?id=912121
24+
const { get: getHarOverlay } = safeRequire(devtools,
25+
"devtools/client/netmonitor/har/toolbox-overlay",
26+
"devtools/netmonitor/har/toolbox-overlay");
2427

2528
// Firebug SDK
2629
const { Trace, TraceError } = require("firebug.sdk/lib/core/trace.js").get(module.id);

0 commit comments

Comments
 (0)