Remove artifacts in start of job instead of relying on --needs (#1569)

Author: firecow

src/handler.ts

@@ -67,7 +67,6 @@ export async function handler (args: any, writeStreams: WriteStreams, jobs: Job[
         generateGitIgnore(cwd, stateDir);
         const time = process.hrtime();
         if (argv.needs || argv.onlyNeeds) {
-            await fs.remove(`${cwd}/${stateDir}/artifacts`);
             await state.incrementPipelineIid(cwd, stateDir);
         }
         const pipelineIid = await state.getPipelineIid(cwd, stateDir);
@@ -88,7 +87,6 @@ export async function handler (args: any, writeStreams: WriteStreams, jobs: Job[
     } else {
         generateGitIgnore(cwd, stateDir);
         const time = process.hrtime();
-        if (childPipelineDepth == 0) await fs.remove(`${cwd}/${stateDir}/artifacts`);
         await state.incrementPipelineIid(cwd, stateDir);
         const pipelineIid = await state.getPipelineIid(cwd, stateDir);
         parser = await Parser.create(argv, writeStreams, pipelineIid, jobs);

src/job.ts

@@ -476,7 +476,7 @@ export class Job {
             const prefix = this.jobData["cache"][index]["key"]["prefix"];
             if (prefix) {
                 return `${index}_${Utils.expandText(prefix, expanded)}-`;
-            };
+            }
 
             const filenames = this.jobData["cache"][index]["key"]["files"].map((p: string) => {
                 const expandP = Utils.expandText(p, expanded);
@@ -806,6 +806,8 @@ export class Job {
 
         if (message.length > 0) writeStreams.stdout(chalk`${this.formattedJobName} {magentaBright ${message}}\n`);
 
+        await fs.remove(`${cwd}/${stateDir}/artifacts/${safeJobName}`);
+
         // Copy git tracked files to build folder if shell isolation enabled.
         if (!imageName && this.argv.shellIsolation) {
             await Utils.rsyncTrackedFiles(cwd, stateDir, `${safeJobName}`);