Remove ARRAY_OPTIONS_FALLBACK constant

Getters defensively normalize strings to arrays, so injectDotenv()
doesn't need to know which options are arrays. No constants needed.

Author: firecow

src/argv.ts

@@ -8,13 +8,6 @@ import {WriteStreams} from "./write-streams.js";
 import chalkBase from "chalk";
 import chalk from "chalk-template";
 
-// Fallback for when _arrayKeys is not provided (e.g. tests calling handler() directly without yargs).
-// The CLI path derives array keys from yargs automatically.
-const ARRAY_OPTIONS_FALLBACK = new Set([
-    "variable", "unsetVariable", "remoteVariables", "device",
-    "network", "volume", "extraHost", "manual", "ignoreSchemaPaths",
-]);
-
 export function splitSemicolonEnvVars (argv: Record<string, any>, arrayKeys: Set<string>, env: Record<string, string | undefined>): void {
     for (const [envKey, envValue] of Object.entries(env)) {
         if (!envKey.startsWith("GCL_") || envValue == null) continue;
@@ -117,10 +110,8 @@ export class Argv {
                     currentVal.unshift(pair);
                 }
             } else if (argv[argKey] == null) {
-                const arrayKeys: Set<string> = argv._arrayKeys ?? ARRAY_OPTIONS_FALLBACK;
-                if (arrayKeys.has(argKey)) {
-                    this.map.set(argKey, value.split(" "));
-                } else if (value === "true") this.map.set(argKey, true);
+                // Work around `dotenv.parse` limitation https://github.com/motdotla/dotenv/issues/51#issuecomment-552559070
+                if (value === "true") this.map.set(argKey, true);
                 else if (value === "false") this.map.set(argKey, false);
                 else if (value === "null") this.map.set(argKey, null);
                 else if (!isNaN(Number(value))) this.map.set(argKey, Number(value));
@@ -160,15 +151,18 @@ export class Argv {
     }
 
     get volume (): string[] {
-        return this.map.get("volume") ?? [];
+        const val = this.map.get("volume") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get network (): string[] {
-        return this.map.get("network") ?? [];
+        const val = this.map.get("network") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get extraHost (): string[] {
-        return this.map.get("extraHost") ?? [];
+        const val = this.map.get("extraHost") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get caFile (): string | null {
@@ -188,7 +182,8 @@ export class Argv {
     }
 
     get remoteVariables (): string[] {
-        return this.map.get("remoteVariables") ?? [];
+        const val = this.map.get("remoteVariables") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get variable (): {[key: string]: string} {
@@ -208,7 +203,8 @@ export class Argv {
     }
 
     get manual (): string[] {
-        return this.map.get("manual") ?? [];
+        const val = this.map.get("manual") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get job (): string[] {
@@ -241,7 +237,8 @@ export class Argv {
     }
 
     get device (): string[] {
-        return this.map.get("device") ?? [];
+        const val = this.map.get("device") ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
     }
 
     get ulimit (): string | null {

src/index.ts

@@ -35,7 +35,6 @@ process.on("SIGUSR2", async () => await cleanupJobResources(jobs));
                 try {
                     const arrayKeys = new Set(yparser.getOptions().array.map((k: string) => camelCase(k)));
                     splitSemicolonEnvVars(argv, arrayKeys, process.env);
-                    (argv as any)._arrayKeys = arrayKeys;
                     await handler(argv, new WriteStreamsProcess(), jobs);
                     const failedJobs = Executor.getFailed(jobs);
                     process.exit(failedJobs.length > 0 ? 1 : 0);