Skip to content

Commit 020d2d7

Browse files
committed
Fix TestMultipleVMs_Isolated
Signed-off-by: Kazuyoshi Kato <[email protected]>
1 parent ad547ec commit 020d2d7

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

runtime/service.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"math"
2121
"net"
2222
"os"
23-
"path/filepath"
2423
"runtime/debug"
2524
"strconv"
2625
"strings"
@@ -497,8 +496,13 @@ func (s *service) createVM(requestCtx context.Context, request *proto.CreateVMRe
497496
namespace = namespaces.Default
498497
}
499498

499+
dir, err := vm.ShimDir(s.config.ShimBaseDir, namespace, s.vmID)
500+
if err != nil {
501+
return err
502+
}
503+
500504
s.logger.Info("creating new VM")
501-
s.jailer, err = newJailer(s.shimCtx, s.logger, filepath.Join(s.config.ShimBaseDir, namespace, s.vmID), s, request)
505+
s.jailer, err = newJailer(s.shimCtx, s.logger, dir.RootPath(), s, request)
502506
if err != nil {
503507
return errors.Wrap(err, "failed to create jailer")
504508
}

runtime/service_integ_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,9 +470,12 @@ func testMultipleExecs(
470470
close(execStdouts)
471471

472472
if jailerConfig != nil {
473+
dir, err := vm.ShimDir(shimBaseDir(), "default", vmIDStr)
474+
require.NoError(t, err)
475+
473476
jailer := &runcJailer{
474477
Config: runcJailerConfig{
475-
OCIBundlePath: filepath.Join(shimBaseDir(), vmIDStr),
478+
OCIBundlePath: dir.RootPath(),
476479
},
477480
vmID: vmIDStr,
478481
}

0 commit comments

Comments
 (0)