Skip to content

Commit 2ba7026

Browse files
committed
Bump Go min version to Go 1.23
Signed-off-by: Austin Vazquez <[email protected]>
1 parent e5a3c77 commit 2ba7026

File tree

11 files changed

+16
-16
lines changed

11 files changed

+16
-16
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
os: ['ubuntu-20.04', 'ubuntu-22.04']
17-
go: ['1.21', '1.22']
17+
go: ['1.23', '1.24']
1818
# Build all variants regardless of failures
1919
fail-fast: false
2020

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ SUBMODULES=_submodules
2828
UID:=$(shell id -u)
2929
GID:=$(shell id -g)
3030

31-
FIRECRACKER_CONTAINERD_BUILDER_IMAGE?=golang:1.21-bullseye
31+
FIRECRACKER_CONTAINERD_BUILDER_IMAGE?=golang:1.23-bullseye
3232
export FIRECRACKER_CONTAINERD_TEST_IMAGE?=localhost/firecracker-containerd-test
3333
export GO_CACHE_VOLUME_NAME?=gocache
3434

@@ -136,7 +136,7 @@ tidy:
136136
./tools/tidy.sh
137137

138138
$(BINPATH)/golangci-lint:
139-
GOBIN=$(BINPATH) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.2
139+
GOBIN=$(BINPATH) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.2
140140
$(BINPATH)/golangci-lint --version
141141

142142
$(BINPATH)/git-validation:

docs/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ You need to have the following things in order to use firecracker-containerd:
4040
* git
4141
* gcc, required by the Firecracker agent for building
4242
* A recent installation of [Docker CE](https://docker.com).
43-
* Go 1.21 or later, which you can download from [here](https://golang.org/dl/).
43+
* Go 1.23 or later, which you can download from [here](https://golang.org/dl/).
4444

4545
## Setup
4646

docs/quickstart.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ files into `/usr/local/bin`.
2828

2929
cd ~
3030

31-
# Install git, Go 1.21, make, curl
31+
# Install git, Go 1.23, make, curl
3232
sudo mkdir -p /etc/apt/sources.list.d
3333
echo "deb http://ftp.debian.org/debian bullseye-backports main" | \
3434
sudo tee /etc/apt/sources.list.d/bullseye-backports.list
3535
sudo DEBIAN_FRONTEND=noninteractive apt-get update
3636
sudo DEBIAN_FRONTEND=noninteractive apt-get \
3737
install --yes \
38-
golang-1.21 \
38+
golang-1.23 \
3939
make \
4040
git \
4141
curl \
@@ -44,8 +44,8 @@ sudo DEBIAN_FRONTEND=noninteractive apt-get \
4444
bc \
4545
gnupg
4646

47-
# Debian's Go 1.21 package installs "go" command under /usr/lib/go-1.21/bin
48-
export PATH=/usr/lib/go-1.21/bin:$PATH
47+
# Debian's Go 1.23 package installs "go" command under /usr/lib/go-1.23/bin
48+
export PATH=/usr/lib/go-1.23/bin:$PATH
4949

5050
cd ~
5151

@@ -93,7 +93,7 @@ sudo yum -y install \
9393
# need to source environment variables afterwards for the existing shell session.
9494
curl -LO https://get.golang.org/$(uname)/go_installer && \
9595
chmod +x go_installer && \
96-
./go_installer -version 1.21 && \
96+
./go_installer -version 1.23 && \
9797
rm go_installer && \
9898
source .bash_profile
9999

docs/remote-snapshotter-getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ You will need the following to use firecracker-containerd with support for remot
1616

1717
* git
1818

19-
* Go 1.21 or later
19+
* Go 1.23 or later
2020

2121
* This repository cloned onto your local machine
2222

examples/cmd/remote-snapshotter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/firecracker-microvm/firecracker-containerd/example/remote-snapshotter
22

3-
go 1.21
3+
go 1.23.0
44

55
require (
66
github.com/containerd/containerd v1.7.16

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/firecracker-microvm/firecracker-containerd
22

3-
go 1.21
3+
go 1.23.0
44

55
require (
66
github.com/awslabs/tc-redirect-tap v0.0.0-20211025175357-e30dfca224c2

tools/docker/Dockerfile.integ-test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# syntax=docker/dockerfile:experimental
22
# Test image that starts up containerd and the devmapper snapshotter. The default CMD will drop to a bash shell. Overrides
33
# to CMD will be provided appended to /bin/bash -c
4-
FROM public.ecr.aws/docker/library/golang:1.21-bullseye
4+
FROM public.ecr.aws/docker/library/golang:1.23-bullseye
55
ENV PATH="/bin:/usr/bin:/usr/local/bin:/sbin:/usr/sbin:/usr/local/sbin:/usr/local/go/bin"
66
ENV INSTALLROOT="/usr/local"
77
ENV DEBIAN_FRONTEND="noninteractive"

tools/docker/Dockerfile.proto-builder

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# express or implied. See the License for the specific language governing
1212
# permissions and limitations under the License.
1313

14-
FROM public.ecr.aws/docker/library/golang:1.21-bullseye
14+
FROM public.ecr.aws/docker/library/golang:1.23-bullseye
1515

1616
RUN apt-get update && apt-get install --yes --no-install-recommends \
1717
libprotobuf-dev=3.12.4-1+deb11u1 \

tools/docker/Dockerfile.runc-builder

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# express or implied. See the License for the specific language governing
1212
# permissions and limitations under the License.
1313

14-
FROM public.ecr.aws/docker/library/golang:1.21-bullseye
14+
FROM public.ecr.aws/docker/library/golang:1.23-bullseye
1515

1616
RUN apt-get update && \
1717
DEBIAN_FRONTEND=noninteractive apt-get -y install libseccomp-dev pkg-config

0 commit comments

Comments
 (0)