Skip to content

Commit 5005907

Browse files
committed
Makefile: replace the 'arch' command with 'uname -m'
tl;dr I'm using Arch linux and ironically can't build this because I don't have the "arch" command. I dug a bit and found it's a wrapper to 'uname -m' so I just replaced it. Long version `arch` is a wrapper for `uname -m` in GNU coreutils [0] However, unlikely the `uname` command, the `arch` command is not as available. It also looks like the arch command is being carried on in UNIX history as a mechanism for retrocompatibility, here's a manpage for solaris [1] saying: "This command is provided for compatibility with previous releases and its use is discouraged. Instead, the uname command is recommended. See uname(1) for usage information." [0]: https://github.com/coreutils/coreutils/blob/00ea4bacf6063ccc125209d5186f8f2382c6f0d4/src/coreutils-arch.c [1]: https://docs.oracle.com/cd/E88353_01/html/E37839/arch-1.html Signed-off-by: Lorenzo Fontana <[email protected]>
1 parent b1c4e32 commit 5005907

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export FIRECRACKER_CONTAINERD_TEST_IMAGE?=localhost/firecracker-containerd-test
3333
export GO_CACHE_VOLUME_NAME?=gocache
3434

3535
# This Makefile uses Firecracker's pre-build Linux kernels for x86_64 and aarch64.
36-
host_arch=$(shell arch)
36+
host_arch=$(shell uname -m)
3737
ifeq ($(host_arch),x86_64)
3838
kernel_sha256sum="ea5e7d5cf494a8c4ba043259812fc018b44880d70bcbbfc4d57d2760631b1cd6"
3939
else ifeq ($(host_arch),aarch64)

0 commit comments

Comments
 (0)