Don't use DeadlineExceeded

Returning DeadlineExceeded is confusing. While it was not graceful,
the requested action itself was completed.

Signed-off-by: Kazuyoshi Kato <[email protected]>

Author: kzys

runtime/service.go

@@ -1187,7 +1187,7 @@ func (s *service) shutdown(
 	if err == nil {
 		return nil
 	}
-	return status.Error(codes.DeadlineExceeded, fmt.Sprintf("the VMM was killed forcibly: %v", err))
+	return status.Error(codes.Internal, fmt.Sprintf("the VMM was killed forcibly: %v", err))
 }
 
 // shutdownLoop sends multiple different shutdown requests to stop the VMM.

runtime/service_integ_test.go

@@ -1392,7 +1392,7 @@ func TestStopVM_Isolated(t *testing.T) {
 			stopFunc: func(ctx context.Context, fcClient fccontrol.FirecrackerService, req proto.CreateVMRequest) {
 				_, err = fcClient.StopVM(ctx, &proto.StopVMRequest{VMID: req.VMID})
 				errCode := status.Code(err)
-				assert.Equal(codes.DeadlineExceeded, errCode, "the error code must be DeadlineExceeded")
+				assert.Equal(codes.Internal, errCode, "the error code must be Internal")
 
 				if req.JailerConfig != nil {
 					// No "signal: ..." error with runc since it traps the signal