Skip to content

Commit 96a454b

Browse files
authored
Merge pull request #407 from kzys/no-cancel
Build all variants like Travis CI
2 parents 40afe03 + 73a81f3 commit 96a454b

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

.github/workflows/build.yaml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,24 @@ jobs:
1818
strategy:
1919
matrix:
2020
go: ['1.11', '1.12', '1.13', '1.14']
21+
# Build all variants regardless of failures
22+
fail-fast: false
2123
name: Go ${{ matrix.go }}
2224

2325
steps:
2426
- uses: actions/checkout@v2
2527
with:
26-
# Assuming that there are at most 20 commits in a single pull
27-
# request, we want to check all commits in a pull request have DCO.
28-
fetch-depth: 20
28+
# By default, the checkout action only fetches the last commit,
29+
# but we want to run DCO check against all commit messages.
30+
# Assuming that a pull request may have multiple commits,
31+
# fetching the single commit doesn't work for us.
32+
#
33+
# While DCO check (on Makefile) checks latest 20 commits,
34+
# the checkout action automatically creates a merge commit
35+
# for merging "master" into a pull request branch.
36+
# So we need to fetch 21 commits (including the merge commit)
37+
# to have 20 actual commits from a pull request.
38+
fetch-depth: 21
2939
- uses: actions/setup-go@v1
3040
with:
3141
go-version: ${{ matrix.go }}

0 commit comments

Comments
 (0)