Skip to content

Commit c458d05

Browse files
committed
Fixes issue where -it on docker fails on AL2
Running docker with -it will fail with `the input device is not a TTY`. To alleviate that error, this change simply removes the -it flag. Signed-off-by: xibz <[email protected]>
1 parent 36a59d9 commit c458d05

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ $(SUBDIRS):
5454
$(MAKE) -C $@ EXTRAGOARGS=$(EXTRAGOARGS)
5555

5656
%-in-docker:
57-
docker run --rm -it \
57+
docker run --rm \
5858
--user $(UID):$(GID) \
5959
--volume $(CURDIR):/src \
6060
--volume $(GO_CACHE_VOLUME_NAME):/go \
@@ -325,7 +325,7 @@ tools/runc-builder-stamp: tools/docker/Dockerfile.runc-builder
325325
touch $@
326326

327327
$(RUNC_BIN): $(RUNC_DIR)/VERSION tools/runc-builder-stamp
328-
docker run --rm -it --user $(UID) \
328+
docker run --rm --user $(UID) \
329329
--volume $(CURDIR)/$(RUNC_DIR):/gopath/src/github.com/opencontainers/runc \
330330
--volume $(CURDIR)/deps:/target \
331331
-e HOME=/tmp \

tools/image-builder/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ builder_stamp:
8888
%-in-docker: builder_stamp
8989
docker run --rm \
9090
--security-opt=apparmor=unconfined \
91-
-it \
9291
--volume $(CURDIR):/src \
9392
--volume /src/tmp \
9493
--cap-add=sys_admin \

0 commit comments

Comments
 (0)