fix use of (*T).Fatalif from non testing goroutine

alakesh · alakesh · commit 5a976634b526 · 2021-04-20T13:52:32.000-07:00
Using t.Fatalif in the goroutine will only exit the goroutine. Use
t.Errorf instead to return failure to the testing function.

Signed-off-by: Alakesh Haloi &lt;alakeshh@amazon.com&gt;
diff --git a/machine_test.go b/machine_test.go
@@ -770,7 +770,8 @@ func TestWaitForSocket(t *testing.T) {
 		time.Sleep(50 * time.Millisecond)
 		_, err := os.Create(filename)
 		if err != nil {
-			t.Fatalf("Unable to create test file %s: %s", filename, err)
+			t.Errorf("Unable to create test file %s: %s", filename, err)
+			return
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -770,7 +770,8 @@ func TestWaitForSocket(t *testing.T) {`
`770`	`770`	`time.Sleep(50 * time.Millisecond)`
`771`	`771`	`_, err := os.Create(filename)`
`772`	`772`	`if err != nil {`
`773`		`- t.Fatalf("Unable to create test file %s: %s", filename, err)`
	`773`	`+ t.Errorf("Unable to create test file %s: %s", filename, err)`
	`774`	`+ return`
`774`	`775`	`}`
`775`	`776`	`}()`
`776`	`777`