Skip to content

Commit 6b08ec7

Browse files
author
Noah Meyerhans
committed
Merge branch 'fc-0.12.0'
#40
2 parents 840c1e3 + 25878e7 commit 6b08ec7

File tree

9 files changed

+24
-163
lines changed

9 files changed

+24
-163
lines changed

client/models/device_state.go

Lines changed: 0 additions & 73 deletions
This file was deleted.

client/models/logger.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/models/network_interface.go

Lines changed: 0 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/operations/operations_client.go

Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/operations/put_mmds_responses.go

Lines changed: 1 addition & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/swagger.yaml

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ info:
44
description: RESTful public-facing API.
55
The API is accessible through HTTP calls on specific URLs carrying JSON modeled data.
66
The transport medium is a Unix Domain Socket.
7-
version: 0.10.1
7+
version: 0.12.0
88
termsOfService: ""
99
contact:
1010
@@ -257,10 +257,8 @@ paths:
257257
schema:
258258
type: object
259259
responses:
260-
201:
261-
description: MMDS data store created
262260
204:
263-
description: MMDS data store updated.
261+
description: MMDS data store created/updated.
264262
400:
265263
description: MMDS data store cannot be created due to bad input.
266264
schema:
@@ -359,14 +357,6 @@ definitions:
359357
- C3
360358
- T2
361359

362-
DeviceState:
363-
type: string
364-
description:
365-
The valid states for a Device. So far, a device can only be in the Attached mode.
366-
Future valid values will be Detaching and Detached.
367-
enum:
368-
- Attached
369-
370360
Drive:
371361
type: object
372362
required:
@@ -452,6 +442,11 @@ definitions:
452442
show_log_origin:
453443
type: boolean
454444
description: Whether or not to include the file path and line number of the log's origin.
445+
options:
446+
type: array
447+
items:
448+
type: string
449+
description: Additional logging options. Only "LogDirtyPages" is supported.
455450

456451
MachineConfiguration:
457452
type: object
@@ -497,8 +492,6 @@ definitions:
497492
$ref: "#/definitions/RateLimiter"
498493
tx_rate_limiter:
499494
$ref: "#/definitions/RateLimiter"
500-
state:
501-
$ref: "#/definitions/DeviceState"
502495

503496
PartialDrive:
504497
type: object

fctesting/machine_mock.go

Lines changed: 6 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

firecracker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ func (f *FirecrackerClient) CreateSyncAction(ctx context.Context, info *models.I
134134
return f.client.Operations.CreateSyncAction(params)
135135
}
136136

137-
func (f *FirecrackerClient) PutMmds(ctx context.Context, metadata interface{}) (*ops.PutMmdsCreated, *ops.PutMmdsNoContent, error) {
137+
func (f *FirecrackerClient) PutMmds(ctx context.Context, metadata interface{}) (*ops.PutMmdsNoContent, error) {
138138
params := ops.NewPutMmdsParams()
139139
params.SetContext(ctx)
140140
params.SetBody(metadata)

machine.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const (
3434
)
3535

3636
// CPUTemplate defines a set of CPU features that are exposed by Firecracker
37-
type CPUTemplate = models.CPUTemplate
37+
type CPUTemplate models.CPUTemplate
3838

3939
// CPUTemplates known by Firecracker. These are passed through directly from the model.
4040
const (
@@ -52,7 +52,7 @@ type Firecracker interface {
5252
PutGuestDriveByID(ctx context.Context, driveID string, drive *models.Drive) (*ops.PutGuestDriveByIDNoContent, error)
5353
PutGuestVsockByID(ctx context.Context, vsockID string, vsock *models.Vsock) (*ops.PutGuestVsockByIDCreated, *ops.PutGuestVsockByIDNoContent, error)
5454
CreateSyncAction(ctx context.Context, info *models.InstanceActionInfo) (*ops.CreateSyncActionNoContent, error)
55-
PutMmds(ctx context.Context, metadata interface{}) (*ops.PutMmdsCreated, *ops.PutMmdsNoContent, error)
55+
PutMmds(ctx context.Context, metadata interface{}) (*ops.PutMmdsNoContent, error)
5656
GetMachineConfig() (*ops.GetMachineConfigOK, error)
5757
}
5858

@@ -469,7 +469,6 @@ func (m *Machine) createNetworkInterface(ctx context.Context, iface NetworkInter
469469
IfaceID: &ifaceID,
470470
GuestMac: iface.MacAddress,
471471
HostDevName: iface.HostDevName,
472-
State: models.DeviceStateAttached,
473472
AllowMmdsRequests: iface.AllowMDDS,
474473
}
475474

@@ -563,13 +562,10 @@ func (m *Machine) startInstance(ctx context.Context) error {
563562

564563
// SetMetadata sets the machine's metadata for MDDS
565564
func (m *Machine) SetMetadata(ctx context.Context, metadata interface{}) error {
566-
respcreated, respnocontent, err := m.client.PutMmds(ctx, metadata)
565+
respnocontent, err := m.client.PutMmds(ctx, metadata)
567566

568567
if err == nil {
569568
var message string
570-
if respcreated != nil {
571-
message = respcreated.Error()
572-
}
573569
if respnocontent != nil {
574570
message = respnocontent.Error()
575571
}

0 commit comments

Comments
 (0)