Remove addVsocksHandler from loadSnapshotHandlerList

CuriousGeorgiy · CuriousGeorgiy · commit 6fe5d922106b · 2023-08-24T16:55:11.000+06:00
According to the firecracker OpenAPI specification [1], creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways. Closes #506 1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
diff --git a/handlers.go b/handlers.go
@@ -321,7 +321,6 @@ var loadSnapshotHandlerList = HandlerList{}.Append(
 	CreateLogFilesHandler,
 	BootstrapLoggingHandler,
 	LoadSnapshotHandler,
-	AddVsocksHandler,
 )
 
 var defaultValidationHandlerList = HandlerList{}.Append(

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,6 @@ var loadSnapshotHandlerList = HandlerList{}.Append(`
`321`	`321`	`CreateLogFilesHandler,`
`322`	`322`	`BootstrapLoggingHandler,`
`323`	`323`	`LoadSnapshotHandler,`
`324`		`- AddVsocksHandler,`
`325`	`324`	`)`
`326`	`325`
`327`	`326`	`var defaultValidationHandlerList = HandlerList{}.Append(`