Skip to content

Commit 852dae1

Browse files
committed
Make setupLogging's error as an error
I'm not so sure why we wanted to treat that as a warning. Signed-off-by: Kazuyoshi Kato <[email protected]>
1 parent 7404c2b commit 852dae1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

handlers.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,9 @@ var BootstrapLoggingHandler = Handler{
169169
Name: BootstrapLoggingHandlerName,
170170
Fn: func(ctx context.Context, m *Machine) error {
171171
if err := m.setupLogging(ctx); err != nil {
172-
m.logger.Warnf("setupLogging() returned %s. Continuing anyway.", err)
173-
} else {
174-
m.logger.Debugf("setup logging: success")
172+
return err
175173
}
176-
174+
m.logger.Debugf("setup logging: success")
177175
return nil
178176
},
179177
}

0 commit comments

Comments
 (0)