You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a section describing DCO / commit signing, exactly the same info as
we already have on firectl repo to keep things consistent.
Signed-off-by: Gavin Inglis <[email protected]>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+58-2Lines changed: 58 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -33,8 +33,9 @@ To send us a pull request, please:
33
33
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
34
34
3. Ensure local tests pass.
35
35
4. Commit to your fork using clear commit messages.
36
-
5. Send us a pull request, answering any default questions in the pull request interface.
37
-
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
36
+
5. Verify all commit messages include [DCO signature](#sign-your-work)
37
+
6. Send us a pull request, answering any default questions in the pull request interface.
38
+
7. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
38
39
39
40
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
40
41
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
@@ -50,6 +51,61 @@ For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of
Use your real name (sorry, no pseudonyms or anonymous contributions.)
104
+
105
+
If you set your `user.name` and `user.email` git configs, you can sign your
106
+
commit automatically with `git commit -s`.
107
+
108
+
53
109
## Security issue notifications
54
110
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
0 commit comments