Skip to content

Commit b023ec9

Browse files
committed
Update pipeline to build with certain go versions and proper build resource cleanup
1. Remove old versions of go, and add new go version 2. Update setting of pipeline steps to make sure cleanup even when failures occured early Signed-off-by: Tony Fang <[email protected]>
1 parent 50e3946 commit b023ec9

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

.buildkite/pipeline.yml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,10 @@ steps:
4949
agents:
5050
queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}"
5151

52-
- wait
52+
# This makes sure next step will run even if previous steps failed
53+
# to make sure we can reach the final step for resource cleanup
54+
- wait: ~
55+
continue_on_failure: true
5356

5457
- label: ':package: install'
5558
env:
@@ -69,7 +72,10 @@ steps:
6972
distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}"
7073
hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}"
7174

72-
- wait
75+
# This makes sure next step will run even if previous steps failed
76+
# to make sure we can reach the final step for resource cleanup
77+
- wait: ~
78+
continue_on_failure: true
7379

7480
- label: lint
7581
command: make lint
@@ -126,7 +132,10 @@ steps:
126132
distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}"
127133
hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}"
128134

129-
- wait
135+
# This makes sure next step will run even if previous steps failed
136+
# to make sure we can reach the final step for resource cleanup
137+
- wait: ~
138+
continue_on_failure: true
130139

131140
- label: ':linux: build Firecracker from the tip of main branch'
132141
commands:
@@ -136,7 +145,10 @@ steps:
136145
distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}"
137146
hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}"
138147

139-
- wait
148+
# This makes sure next step will run even if previous steps failed
149+
# to make sure we can reach the final step for resource cleanup
150+
- wait: ~
151+
continue_on_failure: true
140152

141153
- label: ':hammer: test against Firecracker above'
142154
env:

.github/workflows/go.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
build:
1212
strategy:
1313
matrix:
14-
go: ['1.14', '1.15', '1.16', '1.17', '1.18', '1.19']
14+
go: ['1.17', '1.18', '1.19', '1.20']
1515
os: ['ubuntu-22.04']
1616
fail-fast: false
1717
name: ${{ matrix.os }} / Go ${{ matrix.go }}

0 commit comments

Comments
 (0)