Skip to content

Commit d5e534c

Browse files
authored
README and TODO docs cleanup (#6)
Signed-off-by: Noah Meyerhans <[email protected]>
1 parent 3cb94c7 commit d5e534c

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ This package is a Go library to interact with the Firecracker API. There is
55
also a command-line application that can be used to control Firecracker microVMs
66
called `firectl`.
77

8-
The library and command-line application are not yet complete. See the
9-
[TODO](TODO.md) file for an incomplete list of missing features.
8+
There are some Firecracker features that are not yet supported by the
9+
SDK. Please see the [TODO](TODO.md) file for details. Contributions to
10+
address missing features are welcomed.
1011

1112
Developing
1213
---
@@ -30,16 +31,16 @@ access to filesystems, and network connectivity.
3031

3132
```
3233
Usage of ./cmd/firectl/firectl:
33-
--firecracker-binary= Path to firecracker binary
34+
--firecracker-binary= Path to Firecracker binary
3435
--firecracker-console= Console type (stdio|xterm|none) (default: stdio)
3536
--kernel= Path to the kernel image (default: ./vmlinux)
3637
--kernel-opts= Kernel commandline (default: ro console=ttyS0 noapic reboot=k panic=1 pci=off nomodules)
3738
--root-drive= Path to root disk image
3839
--add-drive= Path to additional drive, suffixed with :ro or :rw, can be specified multiple times
3940
--tap-device= NIC info, specified as DEVICE:MAC
40-
--vmm-log-fifo= FIFO for firecracker logs
41+
--vmm-log-fifo= FIFO for Firecracker logs
4142
--log-level= vmm log level (default: Debug)
42-
--metrics-fifo= FIFO for firecracker metrics
43+
--metrics-fifo= FIFO for Firecracker metrics
4344
-d, --debug Enable debug output
4445
-h, --help Show usage
4546
```
@@ -49,7 +50,9 @@ Usage of ./cmd/firectl/firectl:
4950
Network configuration
5051
---
5152

52-
TODO
53+
Firecracker, by design, only supports Linux tap devices. The SDK
54+
provides facilities to attach a tap device to the Firecracker VM, but
55+
the client is responsible for further configuration.
5356

5457
License
5558
====

TODO.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@ Features
66

77
There's currently no support for specifying rate limits for network or block device access.
88

9-
Better integration with CNI could be nice. Currently, the network namespace should be created ahead of time by and, and the CNI plugins should be run within it to configure the network. Then the firecracker process (`cmd/firectl/firectl` or whatever process is calling the library) can join that namespace and attach to the appropriate TAP device. At least some of this workflow should be integrated into the library.
9+
Support for configuring the Firecracker MMDS.
1010

11-
Integration with the `jailer`
11+
Integration with the [jailer](https://github.com/firecracker-microvm/firecracker/blob/master/docs/jailer.md)
1212

13+
Tests
14+
---
1315
The tests rely on a bunch of hardcoded information and priviledged access. This should be fixed.

0 commit comments

Comments
 (0)