Skip to content

Commit e14476c

Browse files
committed
Because StopVMM() kills Firecracker
Signed-off-by: Kazuyoshi Kato <[email protected]>
1 parent 134a270 commit e14476c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

network_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,11 @@ func TestNetworkMachineCNI(t *testing.T) {
316316

317317
require.NoError(t, m.StopVMM(), "failed to stop machine")
318318
waitCtx, waitCancel := context.WithTimeout(ctx, 3*time.Second)
319-
assert.NoError(t, m.Wait(waitCtx), "failed waiting for machine stop")
319+
320+
// Having an error is fine, since StopVM() kills a Firecracker process.
321+
// Shutdown() uses SendCtrAltDel action, which doesn't work with the kernel we are using here.
322+
// https://github.com/firecracker-microvm/firecracker/issues/1095
323+
assert.NotEqual(t, m.Wait(waitCtx), context.DeadlineExceeded, "failed waiting for machine stop")
320324
waitCancel()
321325

322326
_, err := os.Stat(expectedCacheDirPath)

0 commit comments

Comments
 (0)