Skip to content

Commit 082e58f

Browse files
committed
make tests fail when criteria not found
When criteria is not available, performance tests pass without any errors. This commit makes tests fail in such situation. It lets us know that performance baselines are missing. Signed-off-by: Takahiro Itazuri <[email protected]>
1 parent 7e350d7 commit 082e58f

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

tests/framework/stats/consumer.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
from numbers import Number
88
from typing import Any, Callable
99
from collections import defaultdict
10-
from framework.utils import ExceptionAggregator
10+
from framework.utils import ExceptionAggregator, get_kernel_version
11+
from framework.utils_cpuid import get_cpu_model_name, get_instance_type
1112

1213
from .criteria import CriteriaException
1314
from .metadata import Provider as MetadataProvider
@@ -141,6 +142,16 @@ def process(self, fail_fast=False) -> (dict, dict):
141142
self._failure_aggregator.add_row(fail_msg)
142143
if fail_fast:
143144
raise self._failure_aggregator
145+
else:
146+
self._statistics[ms_name][st_def.name]["outcome"] = "FAILED"
147+
fail_msg = (
148+
f"'{ms_name}/{st_def.name}': Criteria not found for "
149+
f"{get_instance_type()} / {get_cpu_model_name()} / "
150+
f"kernel {get_kernel_version(1)}."
151+
)
152+
self._failure_aggregator.add_row(fail_msg)
153+
if fail_fast:
154+
raise self._failure_aggregator
144155

145156
self._reset()
146157

0 commit comments

Comments
 (0)