tests: remove git safe dir helper

Remove the helper function that marks the `/firecracker` source dir
as safe for git since the config was added to the development
container.
Having the helper here missed the use case where `cargo build` was
called from `devtool build` causing version inconsistencies.

Signed-off-by: Alexandru-Cezar Sardan <[email protected]>

Author: Alexandru-Cezar Sardan

tests/framework/utils.py

@@ -531,30 +531,6 @@ def run_cmd_list_async(cmd_list):
     )
 
 
-def configure_git_safe_directory():
-    """
-    Add the root firecracker git folder to safe.directory config.
-
-    Firecracker root git folder in the container is
-    bind-mounted to a folder on the host which is mapped to a
-    user that is different from the user which runs the integ tests.
-    This difference in ownership is validated against by git.
-    https://github.blog/2022-04-12-git-security-vulnerability-announced/
-    :return: none
-    """
-    # devtool script will set the working directory to FC_ROOT/tests.
-    # We will need the parent for safe.directory configuration
-    working_dir = Path(os.getcwd())
-
-    try:
-        utils.run_cmd('git config --global '
-                      '--add safe.directory {}'.format(working_dir.parent))
-    except ChildProcessError as error:
-        raise Exception("Failure to set the safe.directory "
-                        "git config to [{}] required for gitlint tests"
-                        .format(working_dir.parent)) from error
-
-
 def run_cmd(cmd, ignore_return_code=False, no_shell=False, cwd=None):
     """
     Run a command using the sync function that logs the output.

tests/integration_tests/functional/test_api.py

@@ -1186,7 +1186,6 @@ def test_api_version(test_microvm_with_api):
     # Validate VM version post-boot is the same as pre-boot.
     assert preboot_response.json() == postboot_response.json()
 
-    test_utils.configure_git_safe_directory()
     # Check that the version is the same as `git describe --dirty`.
     out = subprocess.check_output(['git', 'describe', '--dirty']).decode()
 

tests/integration_tests/style/test_gitlint.py

@@ -15,7 +15,6 @@ def test_gitlint():
     os.environ['LC_ALL'] = 'C.UTF-8'
     os.environ['LANG'] = 'C.UTF-8'
 
-    utils.configure_git_safe_directory()
     try:
         utils.run_cmd('gitlint --commits origin/main..HEAD'
                       ' -C ../.gitlint'