Skip to content

Commit 1837da8

Browse files
committed
tmp: Stop tweaking turbo/pstates in perf tests
Writing to the noturbo sysfs immediately locks up the entire instance, so stop doing this for now. Signed-off-by: Patrick Roy <[email protected]>
1 parent 94aa2ef commit 1837da8

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

tools/devtool

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -743,12 +743,6 @@ cmd_test() {
743743

744744
env |grep -P "^(AWS_EMF_|BUILDKITE|CODECOV_)" > env.list
745745
if [[ $performance_tweaks -eq 1 ]]; then
746-
if [[ "$(uname --machine)" == "x86_64" ]]; then
747-
say "Detected CI and performance tests, tuning CPU frequency scaling and idle states for reduced variability"
748-
749-
apply_performance_tweaks
750-
fi
751-
752746
# It seems that even if the tests using huge pages run sequentially on ag=1 agents, right-sizing the huge pages
753747
# pool to the total number of huge pages used across all tests results in spurious failures with pool depletion
754748
# anyway (something else on the host seems to be stealing our huge pages, and we cannot "ear mark" them for
@@ -799,10 +793,6 @@ cmd_test() {
799793

800794
# undo performance tweaks (in case the instance gets recycled for a non-perf test)
801795
if [[ $performance_tweaks -eq 1 ]]; then
802-
if [[ "$(uname --machine)" == "x86_64" ]]; then
803-
unapply_performance_tweaks
804-
fi
805-
806796
echo $huge_pages_old |sudo tee /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages >/dev/null
807797
fi
808798

0 commit comments

Comments
 (0)