Skip to content

Commit 19a5ce1

Browse files
roypatzulinx86
authored andcommitted
devtool: add git-secrets to checkstyle if running outside CI
There's no point in running this in CI, sa by the time a commit reaches the CI its too late to scan for accidentally commited secrets (they'll be out in the open already). So instead, just run it locally when running checkstyle. Signed-off-by: Patrick Roy <[email protected]>
1 parent 324aa71 commit 19a5ce1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tools/devtool

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -951,6 +951,10 @@ cmd_mkdocs() {
951951
}
952952

953953
cmd_checkstyle() {
954+
if [[ -z "$BUILDKITE" ]]; then
955+
cmd_sh "git-secrets --register-aws && git-secrets --scan"
956+
fi
957+
954958
cmd_test --no-build --no-kvm-check -- -n 4 --dist worksteal integration_tests/style || exit 1
955959
cmd_test --no-build --no-kvm-check -- -n 4 --doctest-modules framework || exit 1
956960
}

0 commit comments

Comments
 (0)