Skip to content

Commit 1a9a236

Browse files
committed
refactor: remove unused set_dirty_page_tracking() function
In addition to being unused, it was also wrong, because it only updated the flag on KVM's side, but kept firecracker's tracking disabled. Signed-off-by: Patrick Roy <[email protected]>
1 parent 43247e4 commit 1a9a236

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/vmm/src/lib.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -629,18 +629,6 @@ impl Vmm {
629629
Ok(bitmap)
630630
}
631631

632-
/// Enables or disables KVM dirty page tracking.
633-
pub fn set_dirty_page_tracking(&mut self, enable: bool) -> Result<(), VmmError> {
634-
// This function _always_ results in an ioctl update. The VMM is stateless in the sense
635-
// that it's unaware of the current dirty page tracking setting.
636-
// The VMM's consumer will need to cache the dirty tracking setting internally. For
637-
// example, if this function were to be exposed through the VMM controller, the VMM
638-
// resources should cache the flag.
639-
self.vm
640-
.set_kvm_memory_regions(&self.guest_memory, enable)
641-
.map_err(VmmError::Vm)
642-
}
643-
644632
/// Updates the path of the host file backing the emulated block device with id `drive_id`.
645633
/// We update the disk image on the device and its virtio configuration.
646634
pub fn update_block_device_path(

0 commit comments

Comments
 (0)