fix(test): make test_cargo_audit not ignore return code outside A/B

The pipe through grep was causing any return code of cargo audit to be
overwritten with that of grep (which is always 0). Fix this by using `-o
pipefail`, which changes the return code of a bash pipe to instead be
that of the rightmost failing command (or 0 if none fail). Note that
just -o pipefail will not abort the pipe on a non-zero code (so the grep
will still run even if cargo audit fails).

Suggested-by: Riccardo Mancini <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/integration_tests/security/test_sec_audit.py

@@ -35,6 +35,6 @@ def set_of_vulnerabilities(output: CommandReturn):
         )
 
     git_ab_test_host_command_if_pr(
-        "cargo audit --deny warnings -q --json |grep -Po '{.*}'",
+        "bash -o pipefail -c \"cargo audit --deny warnings -q --json |grep -Po '{.*}'\"",
         comparator=set_did_not_grow_comparator(set_of_vulnerabilities),
     )