test: drop _ab suffix from performance tests

There is nothing that makes these tests specifically "ab" - any test can
be run as an A/B-test as long as it produces more than one data point
for a metric. So drop this suffix. It was only added originally when we
transitioned to A/B-testing and the A/B-capable versions of the tests
had to co-exist with the old baseline version of the tests in separate
files.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

.buildkite/pipeline_perf.py

@@ -18,41 +18,41 @@
 perf_test = {
     "virtio-block-sync": {
         "label": "💿 Virtio Sync Block Performance",
-        "tests": "integration_tests/performance/test_block_ab.py::test_block_performance -k 'not Async'",
+        "tests": "integration_tests/performance/test_block.py::test_block_performance -k 'not Async'",
         "devtool_opts": "-c 1-10 -m 0",
     },
     "virtio-block-async": {
         "label": "💿 Virtio Async Block Performance",
-        "tests": "integration_tests/performance/test_block_ab.py::test_block_performance -k Async",
+        "tests": "integration_tests/performance/test_block.py::test_block_performance -k Async",
         "devtool_opts": "-c 1-10 -m 0",
     },
     "vhost-user-block": {
         "label": "💿 vhost-user Block Performance",
-        "tests": "integration_tests/performance/test_block_ab.py::test_block_vhost_user_performance",
+        "tests": "integration_tests/performance/test_block.py::test_block_vhost_user_performance",
         "devtool_opts": "-c 1-10 -m 0",
         "ab_opts": "--noise-threshold 0.1",
     },
     "network": {
         "label": "📠 Network Latency and Throughput",
-        "tests": "integration_tests/performance/test_network_ab.py",
+        "tests": "integration_tests/performance/test_network.py",
         "devtool_opts": "-c 1-10 -m 0",
         # Triggers if delta is > 0.01ms (10µs) or default relative threshold (5%)
         # only relevant for latency test, throughput test will always be magnitudes above this anyway
         "ab_opts": "--absolute-strength 0.010",
     },
     "snapshot-latency": {
         "label": "📸 Snapshot Latency",
-        "tests": "integration_tests/performance/test_snapshot_ab.py::test_restore_latency integration_tests/performance/test_snapshot_ab.py::test_post_restore_latency integration_tests/performance/test_snapshot_ab.py::test_snapshot_create_latency",
+        "tests": "integration_tests/performance/test_snapshot.py::test_restore_latency integration_tests/performance/test_snapshot.py::test_post_restore_latency integration_tests/performance/test_snapshot.py::test_snapshot_create_latency",
         "devtool_opts": "-c 1-12 -m 0",
     },
     "population-latency": {
         "label": "📸 Memory Population Latency",
-        "tests": "integration_tests/performance/test_snapshot_ab.py::test_population_latency",
+        "tests": "integration_tests/performance/test_snapshot.py::test_population_latency",
         "devtool_opts": "-c 1-12 -m 0",
     },
     "vsock-throughput": {
         "label": "🧦 Vsock Throughput",
-        "tests": "integration_tests/performance/test_vsock_ab.py",
+        "tests": "integration_tests/performance/test_vsock.py",
         "devtool_opts": "-c 1-10 -m 0",
     },
     "memory-overhead": {

tests/README.md

@@ -162,7 +162,7 @@ BUILDKITE_PULL_REQUEST=true BUILDKITE_PULL_REQUEST_BASE_BRANCH=main ./tools/devt
 Firecracker has a special framework for orchestrating long-running A/B-tests
 which run outside the pre-PR CI. Instead, these tests are scheduled to run
 post-merge. Specific tests, such as our
-[snapshot restore latency tests](integration_tests/performance/test_snapshot_ab.py)
+[snapshot restore latency tests](integration_tests/performance/test_snapshot.py)
 contain no assertions themselves, but rather they emit data series using the
 `aws_embedded_metrics` library. When executed by the
 [`tools/ab_test.py`](../tools/ab_test.py) orchestration script, these data