Skip to content

Commit 34e993b

Browse files
committed
refactor(builder): fix unitest
make the test all passed Signed-off-by: tommady <[email protected]>
1 parent da45fb0 commit 34e993b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/vmm/src/builder.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -414,8 +414,6 @@ pub mod x86_64 {
414414
vcpu_count: u8,
415415
exit_evt: &EventFd,
416416
) -> Result<Vec<Vcpu>, VmmError> {
417-
setup_interrupt_controller(vm)?;
418-
419417
let mut vcpus = Vec::with_capacity(vcpu_count as usize);
420418
for cpu_idx in 0..vcpu_count {
421419
let exit_evt = exit_evt.try_clone().map_err(VmmError::EventFd)?;
@@ -479,12 +477,12 @@ fn build_vmm(
479477

480478
// Set up Kvm Vm and register memory regions.
481479
// Build custom CPU config if a custom template is provided.
482-
let vm = Vm::new(kvm_capabilities)
480+
let mut vm = Vm::new(kvm_capabilities)
483481
.map_err(VmmError::Vm)
484-
.map_err(StartMicrovmError::Internal)?;
482+
.map_err(Internal)?;
485483
vm.memory_init(&guest_memory, vm_config.track_dirty_pages)
486484
.map_err(VmmError::Vm)
487-
.map_err(StartMicrovmError::Internal)?;
485+
.map_err(Internal)?;
488486

489487
let vcpus_exit_evt = EventFd::new(libc::EFD_NONBLOCK)
490488
.map_err(VmmError::EventFd)
@@ -512,6 +510,8 @@ fn build_vmm(
512510
.map_err(VmmError::EventFd)
513511
.map_err(Internal)?;
514512

513+
x86_64::setup_interrupt_controller(&mut vm).map_err(Internal)?;
514+
515515
// create pio dev manager with legacy devices
516516
let pio_device_manager = {
517517
// TODO Remove these unwraps.

0 commit comments

Comments
 (0)