Skip to content

Commit 3ea36e6

Browse files
roypatpb8o
authored andcommitted
bench: remove snapshot benchmark from vmm crate
The benchmark in question was booting up microvms and interacting with the file system. These operations go fundamentally against the spirit of a microbenchmark, as they add significant variability (which was observable in the new criterion-based benchmark test, which reported that running the benchmark twice in succession with no code changes yielded statistically significant different measurements). Additionally, the benchmark in question is not part of our current testing suite, and the important part of it is covered by the benchmark in the snapshot crate). Signed-off-by: Patrick Roy <[email protected]>
1 parent a1be1b2 commit 3ea36e6

File tree

2 files changed

+0
-192
lines changed

2 files changed

+0
-192
lines changed

src/vmm/Cargo.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,3 @@ proptest = { version = "1.0.0", default-features = false, features = ["std"] }
4545
[[bench]]
4646
name = "cpu_templates"
4747
harness = false
48-
49-
[[bench]]
50-
name = "snapshots"
51-
harness = false

src/vmm/benches/snapshots.rs

Lines changed: 0 additions & 188 deletions
This file was deleted.

0 commit comments

Comments
 (0)