Skip to content

Commit 4434d33

Browse files
api_server: renamed OkStatus::Updated to NoContent
This status code is going to be used also on create, when we don't need to return a body. Signed-off-by: Andreea Florescu <[email protected]>
1 parent 96e021e commit 4434d33

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

api_server/src/request/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ impl fmt::Debug for SyncRequest {
8888
pub enum OkStatus {
8989
Created,
9090
Ok,
91-
Updated,
91+
NoContent,
9292
}
9393

9494
impl GenerateResponse for OkStatus {
@@ -97,7 +97,7 @@ impl GenerateResponse for OkStatus {
9797
match *self {
9898
Created => empty_response(StatusCode::Created),
9999
Ok => empty_response(StatusCode::Ok),
100-
Updated => empty_response(StatusCode::NoContent),
100+
NoContent => empty_response(StatusCode::NoContent),
101101
}
102102
}
103103
}
@@ -279,7 +279,7 @@ mod tests {
279279
let mut ret = OkStatus::Created.generate_response();
280280
assert_eq!(ret.status(), StatusCode::Created);
281281

282-
ret = OkStatus::Updated.generate_response();
282+
ret = OkStatus::NoContent.generate_response();
283283
assert_eq!(ret.status(), StatusCode::NoContent);
284284
}
285285

vmm/src/device_config/net.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ impl NetworkInterfaceConfigs {
109109
self.validate_unique_mac(&body.guest_mac)?;
110110
self.if_list[index].update_from_body(body);
111111
}
112-
Ok(SyncOkStatus::Updated)
112+
Ok(SyncOkStatus::NoContent)
113113
}
114114

115115
fn validate_unique_mac(&self, mac: &Option<MacAddr>) -> result::Result<(), SyncError> {

vmm/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ impl Vmm {
725725
}
726726
return device_manager
727727
.update_drive(address, new_size)
728-
.map(|_| SyncOkStatus::Updated)
728+
.map(|_| SyncOkStatus::NoContent)
729729
.map_err(|_| {
730730
SyncError::DriveOperationFailed(
731731
DriveError::BlockDeviceUpdateFailed,
@@ -1742,7 +1742,7 @@ mod tests {
17421742
allow_mmds_requests: false,
17431743
};
17441744
match vmm.put_net_device(network_interface) {
1745-
Ok(outcome) => assert!(outcome == SyncOkStatus::Updated),
1745+
Ok(outcome) => assert!(outcome == SyncOkStatus::NoContent),
17461746
Err(_) => assert!(false),
17471747
}
17481748
}

0 commit comments

Comments
 (0)