Skip to content

Commit 4ba71a1

Browse files
committed
Removed rx_partial_writes
- metric is not used Signed-off-by: Milan Dhaduk <[email protected]> Signed-off-by: LDagnachew <[email protected]>
1 parent d8bfb5a commit 4ba71a1

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

src/vmm/src/devices/virtio/net/metrics.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ pub struct NetDeviceMetrics {
161161
pub rx_queue_event_count: SharedIncMetric,
162162
/// Number of events associated with the rate limiter installed on the receiving path.
163163
pub rx_event_rate_limiter_count: SharedIncMetric,
164-
/// Number of RX partial writes to guest.
165-
pub rx_partial_writes: SharedIncMetric,
166164
/// Number of RX rate limiter throttling events.
167165
pub rx_rate_limiter_throttled: SharedIncMetric,
168166
/// Number of events received on the associated tap.
@@ -233,8 +231,6 @@ impl NetDeviceMetrics {
233231
.add(other.rx_queue_event_count.fetch_diff());
234232
self.rx_event_rate_limiter_count
235233
.add(other.rx_event_rate_limiter_count.fetch_diff());
236-
self.rx_partial_writes
237-
.add(other.rx_partial_writes.fetch_diff());
238234
self.rx_rate_limiter_throttled
239235
.add(other.rx_rate_limiter_throttled.fetch_diff());
240236
self.rx_tap_event_count

tests/host_tools/fcmetrics.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def validate_fc_metrics(metrics):
104104
"event_fails",
105105
"rx_queue_event_count",
106106
"rx_event_rate_limiter_count",
107-
"rx_partial_writes",
108107
"rx_rate_limiter_throttled",
109108
"rx_tap_event_count",
110109
"rx_bytes_count",
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
import time
2+
import subprocess
3+
from pathlib import Path
4+
import re
5+
import pytest
6+
7+
8+
def test_clippy_tracing_instrumentation(uvm_plain):
9+
"""
10+
Test Firecracker with Clippy linting and tracing instrumentation enabled.
11+
"""
12+
13+
vm = uvm_plain
14+
vm.spawn(log_file=None)
15+
vm.basic_config(boot_args="log-level=Trace")
16+
17+
log_path = Path(vm.path) / "log"
18+
log_path.touch()
19+
vm.api.logger.put(
20+
log_path=vm.create_jailed_resource(log_path),
21+
level="Trace",
22+
show_level=True,
23+
show_log_origin=True,
24+
)
25+
vm.log_file = log_path
26+
vm.time_api_requests = False
27+
28+
vm.start()
29+
time.sleep(10)
30+
31+
logs = log_path.read_text()
32+
print("Tracing Logs:")
33+
print(logs)
34+
35+
assert ">>" in logs, "Expected tracing markers not found in logs"
36+
37+
vm.kill()

tests/integration_tests/functional/test_pause_resume.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ def verify_net_emulation_paused(metrics):
1313
"""Verify net emulation is paused based on provided metrics."""
1414
net_metrics = metrics["net"]
1515
assert net_metrics["rx_queue_event_count"] == 0
16-
assert net_metrics["rx_partial_writes"] == 0
1716
assert net_metrics["rx_tap_event_count"] == 0
1817
assert net_metrics["rx_bytes_count"] == 0
1918
assert net_metrics["rx_packets_count"] == 0

0 commit comments

Comments
 (0)