Skip to content

Commit 4bd3c6a

Browse files
committed
devtool: Keep boost enabled on AMD
Our dashboards show AMD as being stable with boost enabled as it behaves differently to what we see with Intel. Making the change to test the long term stability. Signed-off-by: Jack Thomson <[email protected]>
1 parent 71fc7d1 commit 4bd3c6a

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tools/devtool

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,6 @@ apply_linux_61_tweaks() {
738738

739739
# Modifies the processors CPU governor and P-state configuration (x86_64 only) for consistent performance. This means
740740
# - Disable turbo boost (Intel only) by writing 1 to /sys/devices/system/cpu/intel_pstate/no_turbo
741-
# - Disable turbo boost (AMD only) by writing 0 to /sys/devices/system/cpu/cpufreq/boost
742741
# - Lock the CPUs' P-state to the highest non-turbo one (Intel only) by writing 100 to /sys/devices/system/cpu/intel_pstate/{min,max}_perf_pct
743742
# - Set the cpu frequency governor to performance by writing "performance" to /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
744743
apply_performance_tweaks() {
@@ -757,8 +756,6 @@ apply_performance_tweaks() {
757756
# https://www.kernel.org/doc/html/v4.12/admin-guide/pm/intel_pstate.html
758757
echo 100 |sudo tee /sys/devices/system/cpu/intel_pstate/min_perf_pct &> /dev/null
759758
echo 100 |sudo tee /sys/devices/system/cpu/intel_pstate/max_perf_pct &> /dev/null
760-
elif [[ -f /sys/devices/system/cpu/cpufreq/boost ]]; then
761-
echo 0 |sudo tee /sys/devices/system/cpu/cpufreq/boost &> /dev/null
762759
fi
763760

764761
# The governor is a linux component that can adjust CPU frequency. "performance" tells it to always run CPUs at
@@ -775,8 +772,6 @@ unapply_performance_tweaks() {
775772
# restore p-state limits
776773
echo $MIN_PERF_PCT |sudo tee /sys/devices/system/cpu/intel_pstate/min_perf_pct &> /dev/null
777774
echo $MAX_PERF_PCT |sudo tee /sys/devices/system/cpu/intel_pstate/max_perf_pct &> /dev/null
778-
elif [[ -f /sys/devices/system/cpu/cpufreq/boost ]]; then
779-
echo 1 | sudo tee /sys/devices/system/cpu/cpufreq/boost &> /dev/null
780775
fi
781776

782777
# We do not reset the governor, as keeping track of each CPUs configured governor is not trivial here. On our CI

0 commit comments

Comments
 (0)