fix: define metric dimensions as strings in A/B ignore list

roypat · roypat · commit 55c04077abb0 · 2025-06-17T13:41:11.000Z
All EMF dimensions are strings, but the allow list for ignoring block
metrics on m8g due to volatility used integers, causing the ignoring to
fail. Change to strings.

Signed-off-by: Patrick Roy &lt;roypat@amazon.co.uk&gt;
diff --git a/tools/ab_test.py b/tools/ab_test.py
@@ -53,8 +53,8 @@
     # boot time metrics
     {"performance_test": "test_boottime", "metric": "resume_time"},
     # block throughput on m8g
-    {"fio_engine": "libaio", "vcpus": 2, "instance": "m8g.metal-24xl"},
-    {"fio_engine": "libaio", "vcpus": 2, "instance": "m8g.metal-48xl"},
+    {"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-24xl"},
+    {"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-48xl"},
 ]
 
 

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@`
`53`	`53`	`# boot time metrics`
`54`	`54`	`{"performance_test": "test_boottime", "metric": "resume_time"},`
`55`	`55`	`# block throughput on m8g`
`56`		`- {"fio_engine": "libaio", "vcpus": 2, "instance": "m8g.metal-24xl"},`
`57`		`- {"fio_engine": "libaio", "vcpus": 2, "instance": "m8g.metal-48xl"},`
	`56`	`+ {"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-24xl"},`
	`57`	`+ {"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-48xl"},`
`58`	`58`	`]`
`59`	`59`
`60`	`60`