Skip to content

Commit 55e3ed2

Browse files
committed
refactor: remove unused set_dirty_page_tracking() function
In addition to being unused, it was also wrong, because it only updated the flag on KVM's side, but kept firecracker's tracking disabled. Signed-off-by: Patrick Roy <[email protected]>
1 parent c23343c commit 55e3ed2

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/vmm/src/lib.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -631,18 +631,6 @@ impl Vmm {
631631
Ok(bitmap)
632632
}
633633

634-
/// Enables or disables KVM dirty page tracking.
635-
pub fn set_dirty_page_tracking(&mut self, enable: bool) -> Result<(), VmmError> {
636-
// This function _always_ results in an ioctl update. The VMM is stateless in the sense
637-
// that it's unaware of the current dirty page tracking setting.
638-
// The VMM's consumer will need to cache the dirty tracking setting internally. For
639-
// example, if this function were to be exposed through the VMM controller, the VMM
640-
// resources should cache the flag.
641-
self.vm
642-
.set_kvm_memory_regions(&self.guest_memory, enable)
643-
.map_err(VmmError::Vm)
644-
}
645-
646634
/// Updates the path of the host file backing the emulated block device with id `drive_id`.
647635
/// We update the disk image on the device and its virtio configuration.
648636
pub fn update_block_device_path(

0 commit comments

Comments
 (0)