Skip to content

Commit 59705ef

Browse files
committed
fix: Remove duplicate set_track_dirty_pages call
The `vm_config.track_dirty_pages` field already gets set in `update_vm_config`. No need to set it to the same value a second time. Signed-off-by: Patrick Roy <[email protected]>
1 parent ea3b738 commit 59705ef

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/vmm/src/resources.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -234,11 +234,6 @@ impl VmResources {
234234
self.vm_config.track_dirty_pages
235235
}
236236

237-
/// Configures the dirty page tracking functionality of the microVM.
238-
pub fn set_track_dirty_pages(&mut self, dirty_page_tracking: bool) {
239-
self.vm_config.track_dirty_pages = dirty_page_tracking;
240-
}
241-
242237
/// Add a custom CPU template to the VM resources
243238
/// to configure vCPUs.
244239
pub fn set_custom_cpu_template(&mut self, cpu_template: CustomCpuTemplate) {

src/vmm/src/rpc_interface.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -565,10 +565,6 @@ impl<'a> PrebootApiController<'a> {
565565
return Err(err);
566566
}
567567

568-
if load_params.enable_diff_snapshots {
569-
self.vm_resources.set_track_dirty_pages(true);
570-
}
571-
572568
// Restore VM from snapshot
573569
let vmm = restore_from_snapshot(
574570
&self.instance_info,

0 commit comments

Comments
 (0)