refactor: remove get_max_size from Queue

The `max_size` field is public, so no need for a getter.

Signed-off-by: Egor Lazarchuk <[email protected]>

Author: ShadowCurse

src/vmm/src/devices/virtio/mmio.rs

@@ -157,7 +157,7 @@ impl MmioTransport {
         //   eventfds, but nothing will happen other than supurious wakeups.
         // . Do not reset config_generation and keep it monotonically increasing
         for queue in self.locked_device().queues_mut() {
-            *queue = Queue::new(queue.get_max_size());
+            *queue = Queue::new(queue.max_size);
         }
     }
 
@@ -253,7 +253,7 @@ impl MmioTransport {
                         }
                         features
                     }
-                    0x34 => self.with_queue(0, |q| u32::from(q.get_max_size())),
+                    0x34 => self.with_queue(0, |q| u32::from(q.max_size)),
                     0x44 => self.with_queue(0, |q| u32::from(q.ready)),
                     0x60 => {
                         // For vhost-user backed devices we need some additional
@@ -489,17 +489,17 @@ pub(crate) mod tests {
         assert!(!d.are_queues_valid());
 
         d.queue_select = 0;
-        assert_eq!(d.with_queue(0, Queue::get_max_size), 16);
+        assert_eq!(d.with_queue(0, |q| q.max_size), 16);
         assert!(d.with_queue_mut(|q| q.size = 16));
         assert_eq!(d.locked_device().queues()[d.queue_select as usize].size, 16);
 
         d.queue_select = 1;
-        assert_eq!(d.with_queue(0, Queue::get_max_size), 32);
+        assert_eq!(d.with_queue(0, |q| q.max_size), 32);
         assert!(d.with_queue_mut(|q| q.size = 16));
         assert_eq!(d.locked_device().queues()[d.queue_select as usize].size, 16);
 
         d.queue_select = 2;
-        assert_eq!(d.with_queue(0, Queue::get_max_size), 0);
+        assert_eq!(d.with_queue(0, |q| q.max_size), 0);
         assert!(!d.with_queue_mut(|q| q.size = 16));
 
         assert!(!d.are_queues_valid());

src/vmm/src/devices/virtio/queue.rs

@@ -462,11 +462,6 @@ impl Queue {
         }
     }
 
-    /// Maximum size of the queue.
-    pub fn get_max_size(&self) -> u16 {
-        self.max_size
-    }
-
     /// Return the actual size of the queue, as the driver may not set up a
     /// queue as big as the device allows.
     pub fn actual_size(&self) -> u16 {
@@ -1131,7 +1126,7 @@ mod verification {
     fn verify_actual_size() {
         let ProofContext(queue, _) = kani::any();
 
-        assert!(queue.actual_size() <= queue.get_max_size());
+        assert!(queue.actual_size() <= queue.max_size);
         assert!(queue.actual_size() <= queue.size);
     }
 

src/vmm/src/devices/virtio/vhost_user.rs

@@ -416,7 +416,7 @@ impl<T: VhostUserHandleBackend> VhostUserHandleImpl<T> {
 
         for (queue_index, queue, queue_evt) in queues.iter() {
             let config_data = VringConfigData {
-                queue_max_size: queue.get_max_size(),
+                queue_max_size: queue.max_size,
                 queue_size: queue.actual_size(),
                 flags: 0u32,
                 desc_table_addr: mem