Skip to content

Commit 63781e8

Browse files
committed
test: do not run criterion benchmarks in no_block_pr
These tests have been failing consistently in our CI for as long as I can remember. While each individual test false positive rate is not high, the fact that we run many of them in a multitude of combinations means that at every CI run at least one fails. With this change, we are disabling them in the PR - Optional step. We will still be able to notice performance regressions from the performance tests, so we're not losing much test coverage. We're not completely deleting them because they can be useful for deep dives and for verifying changes in those particular parts of the codebase. Signed-off-by: Riccardo Mancini <[email protected]>
1 parent 6bac528 commit 63781e8

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/integration_tests/performance/test_benchmarks.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919

2020
@pytest.mark.no_block_pr
21+
@pytest.mark.nonci
2122
@pytest.mark.timeout(900)
2223
def test_no_regression_relative_to_target_branch():
2324
"""

0 commit comments

Comments
 (0)