feat(devctr): add checkbuild command to cargo-check specific arch

Add a new checkbuild command to the devtool so that contributors can
run cargo-check against all supported architectures.

There is currently no easy way to check compilation against a different
architectures. This causes unnecessary back and forth in reviews where
the contributor has no easy access to the other architecture.

Signed-off-by: Riccardo Mancini <[email protected]>

Author: Manciukic

.github/pull_request_template.md

@@ -16,6 +16,8 @@ Certificate of Origin and signing off your commits, please check
 ## PR Checklist
 
 - [ ] I have read and understand [CONTRIBUTING.md][3].
+- [ ] I have run `tools/devtool checkbuild --all` to verify that the PR passes
+  build checks on all supported architectures.
 - [ ] I have run `tools/devtool checkstyle` to verify that the PR passes the
   automated style checks.
 - [ ] I have described what is done in these changes, why they are needed, and

tools/devtool

@@ -427,6 +427,9 @@ cmd_help() {
 
     checkstyle
         Run style checks
+
+    checkbuild [--all|-m x86_64|aarch64] [-v|--verbose]
+        Run cargo check on the target architecture (supports cross compilation).
 EOF
 }
 
@@ -959,6 +962,56 @@ cmd_checkstyle() {
     cmd_test --no-build --no-kvm-check -- -n 4 --doctest-modules framework || exit 1
 }
 
+cmd_checkbuild() {
+    TARGET_ARCH=$(uname -m)
+
+    declare -A PACKAGES=(
+        [x86_64]="gcc-x86-64-linux-gnu g++-x86-64-linux-gnu libc6-dev-amd64-cross linux-libc-dev-amd64-cross"
+        [aarch64]="gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libc6-dev-arm64-cross linux-libc-dev-arm64-cross"
+    )
+    APT_QUIET="-qq > /dev/null"
+
+    while [ $# -gt 0 ]; do
+        case "$1" in
+            "-h"|"--help") { cmd_help; exit 1; } ;;
+            "-v"|"--verbose") { APT_QUIET=""; } ;;
+            "-m"|"--arch") { TARGET_ARCH=$2; shift; } ;;
+            "--all") {
+                shift
+                for arch in ${!PACKAGES[@]}; do
+                    say "Running checkbuild -m $arch $@"
+                    cmd_checkbuild -m $arch $@ || return $?
+                    done
+                }
+                say "Build check passed for ${!PACKAGES[@]}"
+                return 0
+                ;;
+            *)
+                die "Unknown argument: $1. Please use --help for help."
+        ;;
+        esac
+        shift
+    done
+
+    if [[ ! -v PACKAGES[$TARGET_ARCH] ]]; then
+        die "Unknown architecture: $TARGET_ARCH. Supported architectures: ${!PACKAGES[@]}"
+    fi
+
+    # Use GNU target to check build as musl has issues with cross-compilation
+    CARGO_TARGET="${TARGET_ARCH}-unknown-linux-gnu"
+    CMD="cargo check --target $CARGO_TARGET --all && \
+        cargo clippy --target $CARGO_TARGET --all --profile test -- -D warnings"
+    if [ $TARGET_ARCH != $(uname -m) ]; then
+        CMD="export DEBIAN_FRONTEND=noninteractive && \
+            apt update $APT_QUIET && \
+            apt install -y ${PACKAGES[$TARGET_ARCH]} $APT_QUIET && \
+            rustup target add $CARGO_TARGET && \
+            $CMD"
+    fi
+    cmd_sh "$CMD" || die "Error running build checks for $TARGET_ARCH"
+    say "Build check passed for $TARGET_ARCH"
+}
+
 # Check if able to run firecracker.
 # ../docs/getting-started.md#prerequisites
 ensure_kvm_rw () {