Skip to content

Commit 752efcb

Browse files
committed
refactor: cleanup error propagation in snapshot_emory_to_file
We can just immediately propagate errors to the caller using `?` syntax, which saves us the "if (...).is_ok()" check. Signed-off-by: Patrick Roy <[email protected]>
1 parent 768440e commit 752efcb

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/vmm/src/vstate/vm.rs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -262,18 +262,14 @@ impl Vm {
262262
match snapshot_type {
263263
SnapshotType::Diff => {
264264
let dirty_bitmap = self.get_dirty_bitmap()?;
265-
self.guest_memory().dump_dirty(&mut file, &dirty_bitmap)
265+
self.guest_memory().dump_dirty(&mut file, &dirty_bitmap)?;
266266
}
267267
SnapshotType::Full => {
268-
let dump_res = self.guest_memory().dump(&mut file);
269-
if dump_res.is_ok() {
270-
self.reset_dirty_bitmap();
271-
self.guest_memory().reset_dirty();
272-
}
273-
274-
dump_res
268+
self.guest_memory().dump(&mut file)?;
269+
self.reset_dirty_bitmap();
270+
self.guest_memory().reset_dirty();
275271
}
276-
}?;
272+
};
277273

278274
file.flush()
279275
.map_err(|err| MemoryBackingFile("flush", err))?;

0 commit comments

Comments
 (0)