test: hack: tmp: disable serial for A/B tests

When A/B-testing, the "A" revision firecracker binary does not know
about the new --serial-out-path CLI argument. Thus, disable the serial
console for all A/B-tests. It gets quite ugly to do for the
vulnerability tests, because the .spawn() call is burried deep in the
fixtures.

This commit should be reverted after merging the PR

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/conftest.py

@@ -581,7 +581,10 @@ def uvm_booted(
 ):
     """Return a booted uvm"""
     uvm = microvm_factory.build(guest_kernel, rootfs)
-    uvm.spawn()
+    if getattr(microvm_factory, "hack_no_serial", False):
+        uvm.spawn(serial_log_file=None)
+    else:
+        uvm.spawn()
     uvm.basic_config(vcpu_count=vcpu_count, mem_size_mib=mem_size_mib)
     uvm.set_cpu_template(cpu_template)
     uvm.add_net_iface()

tests/integration_tests/performance/test_block.py

@@ -176,7 +176,7 @@ def test_block_performance(
     Execute block device emulation benchmarking scenarios.
     """
     vm = microvm_factory.build(guest_kernel_acpi, rootfs, monitor_memory=False)
-    vm.spawn(log_level="Info", emit_metrics=True)
+    vm.spawn(log_level="Info", emit_metrics=True, serial_log_file=None)
     vm.basic_config(vcpu_count=vcpus, mem_size_mib=GUEST_MEM_MIB)
     vm.add_net_iface()
     # Add a secondary block device for benchmark tests.
@@ -227,7 +227,7 @@ def test_block_vhost_user_performance(
     """
 
     vm = microvm_factory.build(guest_kernel_acpi, rootfs, monitor_memory=False)
-    vm.spawn(log_level="Info", emit_metrics=True)
+    vm.spawn(log_level="Info", emit_metrics=True, serial_log_file=None)
     vm.basic_config(vcpu_count=vcpus, mem_size_mib=GUEST_MEM_MIB)
     vm.add_net_iface()
 

tests/integration_tests/performance/test_boottime.py

@@ -107,7 +107,7 @@ def test_boottime(
     for i in range(10):
         vm = microvm_factory.build(guest_kernel_acpi, rootfs_rw)
         vm.jailer.extra_args.update({"boot-timer": None})
-        vm.spawn()
+        vm.spawn(serial_log_file=None)
         vm.basic_config(
             vcpu_count=vcpu_count,
             mem_size_mib=mem_size_mib,

tests/integration_tests/performance/test_memory_overhead.py

@@ -39,7 +39,7 @@ def test_memory_overhead(
 
     for _ in range(5):
         microvm = microvm_factory.build(guest_kernel_acpi, rootfs, monitor_memory=False)
-        microvm.spawn(emit_metrics=True)
+        microvm.spawn(emit_metrics=True, serial_log_file=None)
         microvm.basic_config(vcpu_count=vcpu_count, mem_size_mib=mem_size_mib)
         microvm.add_net_iface()
         microvm.start()

tests/integration_tests/performance/test_network.py

@@ -46,7 +46,7 @@ def network_microvm(request, microvm_factory, guest_kernel_acpi, rootfs):
     guest_vcpus = request.param
 
     vm = microvm_factory.build(guest_kernel_acpi, rootfs, monitor_memory=False)
-    vm.spawn(log_level="Info", emit_metrics=True)
+    vm.spawn(log_level="Info", emit_metrics=True, serial_log_file=None)
     vm.basic_config(vcpu_count=guest_vcpus, mem_size_mib=guest_mem_mib)
     vm.add_net_iface()
     vm.start()

tests/integration_tests/performance/test_snapshot.py

@@ -51,7 +51,7 @@ def boot_vm(self, microvm_factory, guest_kernel, rootfs) -> Microvm:
             rootfs,
             monitor_memory=False,
         )
-        vm.spawn(log_level="Info", emit_metrics=True)
+        vm.spawn(log_level="Info", emit_metrics=True, serial_log_file=None)
         vm.time_api_requests = False
         vm.basic_config(
             vcpu_count=self.vcpus,
@@ -264,7 +264,7 @@ def test_snapshot_create_latency(
     """Measure the latency of creating a Full snapshot"""
 
     vm = microvm_factory.build(guest_kernel_linux_5_10, rootfs, monitor_memory=False)
-    vm.spawn()
+    vm.spawn(serial_log_file=None)
     vm.basic_config(
         vcpu_count=2,
         mem_size_mib=512,

tests/integration_tests/performance/test_vsock.py

@@ -95,7 +95,7 @@ def test_vsock_throughput(
 
     mem_size_mib = 1024
     vm = microvm_factory.build(guest_kernel_acpi, rootfs, monitor_memory=False)
-    vm.spawn(log_level="Info", emit_metrics=True)
+    vm.spawn(log_level="Info", emit_metrics=True, serial_log_file=None)
     vm.basic_config(vcpu_count=vcpus, mem_size_mib=mem_size_mib)
     vm.add_net_iface()
     # Create a vsock device

tests/integration_tests/security/test_vulnerabilities.py

@@ -211,6 +211,7 @@ def microvm_factory_a(record_property):
     bin_dir = git_clone(Path("../build") / revision_a, revision_a).resolve()
     record_property("firecracker_bin", str(bin_dir / "firecracker"))
     uvm_factory = MicroVMFactory(bin_dir)
+    uvm_factory.hack_no_serial = True
     yield uvm_factory
     uvm_factory.kill()